This repository has been archived by the owner. It is now read-only.

Progress on JAXB RI modularization. #1158

Merged
merged 2 commits into from Dec 7, 2017

Conversation

Projects
None yet
2 participants
@bravehorsie
Member

bravehorsie commented Dec 1, 2017

Everything is now loaded as native modules. I have created test clients running unzipped jaxb-ri as native modules.

Here is set of --list-modules for all dependencies of jaxb runtime, xjc and jxc.
ant ant.jar automatic
ant.launcher ant-launcher.jar automatic
com.sun.codemodel codemodel.jar
com.sun.istack.runtime istack-commons-runtime.jar
com.sun.istack.tools istack-commons-tools.jar
com.sun.tools.jxc jaxb-jxc.jar
com.sun.tools.rngom rngom.jar
com.sun.tools.xjc jaxb-xjc.jar
com.sun.xml.bind jaxb-runtime.jar
com.sun.xml.dtdparser dtd-parser.jar
com.sun.xml.fastinfoset FastInfoset.jar
com.sun.xml.txw2 txw2.jar
com.sun.xml.xsom xsom.jar
org.jvnet.staxex stax-ex.jar
relaxngDatatype relaxngDatatype.jar automatic

So the only without module-info declaration left are relaxngDatatype (we don't own source), ant and ant.launcher.

After merge we should be able to run TCKs and load jaxb as native modules.

Progress on JAXB RI modularization.
Signed-off-by: Roman Grigoriadi <roman.grigoriadi@oracle.com>

@bravehorsie bravehorsie requested review from lukasj and m0mus Dec 1, 2017

@bravehorsie

This comment has been minimized.

Show comment
Hide comment
@bravehorsie

bravehorsie Dec 1, 2017

Member

Module names are still open question. I had to preset it but it should not be considered final.

Member

bravehorsie commented Dec 1, 2017

Module names are still open question. I had to preset it but it should not be considered final.

@bravehorsie bravehorsie requested a review from zhengjl Dec 1, 2017

@zhengjl

move module-info.java to src/main/java may cause build failure with JDK 8

@bravehorsie

This comment has been minimized.

Show comment
Hide comment
@bravehorsie

bravehorsie Dec 5, 2017

Member

Do we still need to build it with JDK8 now when 9 is final and we have working TCKs on 9?

Member

bravehorsie commented Dec 5, 2017

Do we still need to build it with JDK8 now when 9 is final and we have working TCKs on 9?

Removed module dependency to ant and relaxngDatatype, those can now b…
…e placed on classpath instead.

Signed-off-by: Roman Grigoriadi <roman.grigoriadi@oracle.com>
@zhengjl

This comment has been minimized.

Show comment
Hide comment
@zhengjl

zhengjl Dec 6, 2017

Member

If we do not support JDK 8 in master branch, should we create a branch for JDK 8 backward?

Member

zhengjl commented Dec 6, 2017

If we do not support JDK 8 in master branch, should we create a branch for JDK 8 backward?

@bravehorsie

This comment has been minimized.

Show comment
Hide comment
@bravehorsie

bravehorsie Dec 6, 2017

Member

No I don't think its needed, we can now build all with 9 with 1.7 target with an exception to module-infos. Produced jars will still be backwards compatible down to 1.7 and tests are now ready to be run on 9.

Member

bravehorsie commented Dec 6, 2017

No I don't think its needed, we can now build all with 9 with 1.7 target with an exception to module-infos. Produced jars will still be backwards compatible down to 1.7 and tests are now ready to be run on 9.

@bravehorsie bravehorsie merged commit e74717f into master Dec 7, 2017

@bravehorsie bravehorsie deleted the jaxb-modularization-2 branch Aug 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.