Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
JDK-8220222: specify clearly gradle project dependencies #401
In order to import the openjdk-jfx project correctly in the different IDEs, the dependencies should be clearly defined. At the moment the project is working in IDEA and Netbeans correctly.
Currently, Netbeans has an issue open with gradle and jigsaw (https://issues.apache.org/jira/browse/NETBEANS-2004 and kelemen/netbeans-gradle-project#417).
So the only IDE working 100% correctly is IDEA for importing the openjdk-jfx project.
kevinrushforth left a comment
I left some specific feedback below, but otherwise looks fine. You will need to fetch the latest upstream changes and merge (not rebase) the upstream
@kevinrushforth thanks for your review. You are right in all points and I integrated all your reviews and merged it with the develop branch of upstream.
This checkin enables full working on OpenJFX in IntelliJ IDEA Version 20.18.3 or higher.
The checked in IntelliJ project files should be removed, because they do not work and are misleading.