From dce6020b464575b6f8514aa9c9132b9e9d95f1ce Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakub=20=C5=A0tiller?= Date: Thu, 13 May 2021 09:11:38 +0200 Subject: [PATCH] Do not try to connect to zookeeper if connection string is empty (#428) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Jakub Štiller --- .../provectus/kafka/ui/service/ZookeeperService.java | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/ZookeeperService.java b/kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/ZookeeperService.java index fb0ec918b4c..02123ac9576 100644 --- a/kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/ZookeeperService.java +++ b/kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/ZookeeperService.java @@ -7,6 +7,7 @@ import lombok.extern.log4j.Log4j2; import org.I0Itec.zkclient.ZkClient; import org.springframework.stereotype.Service; +import org.springframework.util.StringUtils; @Service @RequiredArgsConstructor @@ -17,10 +18,12 @@ public class ZookeeperService { public boolean isZookeeperOnline(KafkaCluster kafkaCluster) { var isConnected = false; - var zkClient = getOrCreateZkClient(kafkaCluster); - log.debug("Start getting Zookeeper metrics for kafkaCluster: {}", kafkaCluster.getName()); - if (zkClient != null) { - isConnected = isZkClientConnected(zkClient); + if (StringUtils.hasText(kafkaCluster.getZookeeper())) { + var zkClient = getOrCreateZkClient(kafkaCluster); + log.debug("Start getting Zookeeper metrics for kafkaCluster: {}", kafkaCluster.getName()); + if (zkClient != null) { + isConnected = isZkClientConnected(zkClient); + } } return isConnected; }