Skip to content

Commit

Permalink
lightwindow.js: use about:blank instead of javascript:false
Browse files Browse the repository at this point in the history
about:blank works for all browsers and doesn't use inline javascript
therefore doesn't violate a content security policy which prohibits
inline script.
  • Loading branch information
candrews authored and evernat committed May 7, 2021
1 parent 39e7aab commit 8601f19
Showing 1 changed file with 2 additions and 2 deletions.
Expand Up @@ -174,7 +174,7 @@ lightwindow.prototype = {
'<a href="#" id="lightwindow_next" >'+
'<span id="lightwindow_next_title"></span>'+
'</a>'+
'<iframe name="lightwindow_navigation_shim" id="lightwindow_navigation_shim" src="javascript:false;" frameBorder="0" scrolling="no"></iframe>'+
'<iframe name="lightwindow_navigation_shim" id="lightwindow_navigation_shim" src="about:blank" frameBorder="0" scrolling="no"></iframe>'+
'</div>'+
'<div id="lightwindow_galleries">'+
'<div id="lightwindow_galleries_tab_container" >'+
Expand Down Expand Up @@ -206,7 +206,7 @@ lightwindow.prototype = {
loading : '<div id="lightwindow_loading" >'+
'<img src="?resource=ajax-loading.gif" alt="loading" />'+
//'<span>Loading or <a href="javascript: myLightWindow.deactivate();">Cancel</a></span>'+
'<iframe name="lightwindow_loading_shim" id="lightwindow_loading_shim" src="javascript:false;" frameBorder="0" scrolling="no"></iframe>'+
'<iframe name="lightwindow_loading_shim" id="lightwindow_loading_shim" src="about:blank" frameBorder="0" scrolling="no"></iframe>'+
'</div>',
iframe : '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">'+
'<html xmlns="http://www.w3.org/1999/xhtml">'+
Expand Down

0 comments on commit 8601f19

Please sign in to comment.