Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java Melody does not correctly work with Servlet 2.5 #492

Closed
gosuvigi opened this issue Sep 2, 2015 · 1 comment
Closed

Java Melody does not correctly work with Servlet 2.5 #492

gosuvigi opened this issue Sep 2, 2015 · 1 comment

Comments

@gosuvigi
Copy link

gosuvigi commented Sep 2, 2015

Inside the MonitoringFilter class, inside the doFilter method the following call:

if (!httpRequest.isAsyncStarted())

does not work in Servlet 2.5 since the async feature does not exist, it throws:
java.lang.NoSuchMethodError: javax.servlet.http.HttpServletRequest.isAsyncStarted()Z

@evernat
Copy link
Member

evernat commented Sep 2, 2015

True. I almost forgot about Servlet api 2.5 which is quite old now.
In fact, the call to isAsyncStarted was added recently in javamelody (v1.57.0).
This is fixed in master and ready for the next release.
A nightly build is available including the fix:
https://javamelody.ci.cloudbees.com/job/javamelody/

@evernat evernat closed this as completed Sep 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants