Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When downloading more than 2GB, assertionError may occur #847

Closed
rPraml opened this issue Jul 25, 2019 · 1 comment
Closed

When downloading more than 2GB, assertionError may occur #847

rPraml opened this issue Jul 25, 2019 · 1 comment

Comments

@rPraml
Copy link

@rPraml rPraml commented Jul 25, 2019

We streamed a file more than 2GB through javaMelody and got an assertion error at Counter.addRequest in line assert responseSize >= -1; // -1 pour requêtes sql

https://github.com/javamelody/javamelody/blob/master/javamelody-core/src/main/java/net/bull/javamelody/internal/model/Counter.java#L487

This may happen through integer overflow and the int got negative. So responseSize should be effectively changed to long in CounterResponseStream and all methods that access it.

@evernat evernat closed this in 29b8e30 Jul 25, 2019
@evernat

This comment has been minimized.

Copy link
Member

@evernat evernat commented Jul 25, 2019

Fixed by 29b8e30 and ready to be released in 1.79 (soon).
Thanks for the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.