JavaMelodyAutoConfiguration conditional on Servlet#1206
Merged
Conversation
JavaMelodyAutoConfiguration only works for servlet type web applications so it should be conditional on that application type. Without this conditional, attempts to run a reactive application with the JavaMelody classes present fails to start with: ``` org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'monitoringSessionListener' defined in class path resource [net/bull/javamelody/JavaMelodyAutoConfiguration.class]: Unsatisfied dependency expressed through method 'monitoringSessionListener' parameter 0: No qualifying bean of type 'jakarta.servlet.ServletContext' available: expected at least 1 bean which qualifies as autowire candidate. ``` With this conditional, the application starts (without JavaMelody, of course).
Member
|
thanks @candrews |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JavaMelodyAutoConfiguration only works for servlet type web applications so it should be conditional on that application type.
Without this conditional, attempts to run a reactive application with the JavaMelody classes present fails to start with:
With this conditional, the application starts (without JavaMelody, of course).