Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XSS in graph page #555

Merged
merged 1 commit into from Jun 10, 2016
Merged

Fix XSS in graph page #555

merged 1 commit into from Jun 10, 2016

Conversation

thelmstedt
Copy link
Contributor

In this context graphName is rendered inside a <script></script> block, so we need to htmlEncode to avoid XSS vulnerabilities like: /monitoring?part=graph&graph=usedMemory<%2fscript><script>alert(1)<%2fscript>

In this context graphName is rendered inside a <script></script> block, so we need to htmlEncode to avoid XSS vulnerabilities like: /monitoring?part=graph&graph=usedMemory<%2fscript><script>alert(1)<%2fscript>
@thelmstedt
Copy link
Contributor Author

thelmstedt commented Jun 7, 2016

This came up in an internal pentest. It seems this path controls the rendering of graphs/sql/errors, which covers my usecases. I'm unsure if the fix needs to be applied anywhere else.

@evernat
Copy link
Member

evernat commented Jun 10, 2016

ok thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants