Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

run whenever from the release_path instead of the current_path in update_crontab task #247

Closed
wants to merge 2 commits into from

3 participants

@cap10morgan

According to the capistrano docs: https://raw.github.com/mpasternacki/capistrano-documentation-support-files/master/default-execution-path/Capistrano%20Execution%20Path.jpg, deploy:finalize_update is run before deploy:symlink.

Whenever hooks its update_crontab task into the before deploy:finalize_update hook, which means the current_path will still point at the last successful deployment, not the one we're currently deploying. It should use current_path instead for this.

@travisbot

This pull request passes (merged 3d6e01e into e23022b).

@cap10morgan

Hang on, this commit cherry-pick didn't work quite right. Sending up another commit shortly.

@cap10morgan

That's better.

@travisbot

This pull request passes (merged a374a13 into e23022b).

@javan
Owner

#233 needs to be addressed first and this will become a non-issue. Thanks for your attention. I haven't had time to dedicate to Whenever recently.

@cap10morgan

Yeah, PR #233 looks like it would solve this problem nicely. I'll merge it into my fork and test. I'll report on the results in that pull request. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 21, 2012
  1. @cap10morgan

    try running whenever from the release_path instead of the current_path

    cap10morgan authored
    Conflicts:
    	lib/whenever/capistrano/recipes.rb
  2. @cap10morgan
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  lib/whenever/capistrano/recipes.rb
View
2  lib/whenever/capistrano/recipes.rb
@@ -34,7 +34,7 @@
end
end
- run "cd #{fetch :current_path} && #{fetch :whenever_command} #{fetch :whenever_update_flags}", options
+ run "cd #{fetch :release_path} && #{fetch :whenever_command} #{fetch :whenever_update_flags}", options
end
end
Something went wrong with that request. Please try again.