Makes sure capistrano cd's to the right directory when executing a deploy:rollback #318

Merged
merged 2 commits into from Feb 22, 2013

Projects

None yet

5 participants

@jeroenj
Contributor
jeroenj commented Feb 11, 2013

This is an update of #300 where the args for rollback are abstracted into the capistrano support lib.
Though, I'm not 100% happy with this code since it moves arguments logic into the helper where I think it should be in the recipe itself. What do you think?

@javan javan merged commit d25009d into javan:master Feb 22, 2013

1 check passed

default The Travis build passed
Details
@javan
Owner
javan commented Feb 22, 2013

❤️

@jaredmoody

Thanks, this bit me yesterday. Can we get a version bump and release so we can update?

@loopj
loopj commented Mar 16, 2013

👍 on releasing a new ruby gem release, we are affected by failing rollbacks

@jeroenj jeroenj deleted the jeroenj:cap-rollback branch Mar 19, 2013
@stantona

For some reason this is still failing for me. I'm using master version in Gemfile. Am I missing anything obvious?
Here's the log:
https://gist.github.com/stantona/0ab842f53fdab0f9d7ae

@jeroenj
Contributor
jeroenj commented Mar 27, 2013

Could you verify by executing bundle open whenever that you have the correct version of recipe in you Gemfile?
Have a look in the files in lib/whenever/capistrano if they match the ones from the current master (or this pull request).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment