Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call inspect on the time that couldn't be parsed #744

Merged
merged 1 commit into from May 3, 2018

Conversation

@ignisf
Copy link
Contributor

ignisf commented May 3, 2018

This commit makes the error message clearer when parsing fails due to a trailing
space in a string with cron syntax.

Fixes #726

Copy link
Collaborator

benlangfeld left a comment

Not keen on the docs, but everything else looks fine.

README.md Outdated
@@ -70,7 +70,7 @@ every :sunday, at: '12pm' do # Use any day of the week or :weekend, :weekday
runner "Task.do_something_great"
end
every '0 0 27-31 * *' do
every '0 0 27-31 * *' do # Note the absence of trailing space

This comment has been minimized.

Copy link
@benlangfeld

benlangfeld May 3, 2018

Collaborator

I don’t think pointing out this edge case in the happy path of documentation is necessary.

This commit makes the error message clearer when parsing fails due to a trailing
space in a string with cron syntax.

Fixes #726
Fixes #730
@ignisf

This comment has been minimized.

Copy link
Contributor Author

ignisf commented May 3, 2018

Removed the comment in the README

@benlangfeld benlangfeld merged commit 023ec1e into javan:master May 3, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.