Prevent run-time exception when image mounting fails #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyoo980
commented
Nov 23, 2023
| .filter(s -> s.contains(mountFolder.getAbsolutePath())) | ||
| .map(s -> StringUtils.normalizeSpace(s)) | ||
| .map(s -> s.split(" ")[0]) | ||
| .findFirst().get(); |
There was a problem hiding this comment.
This call to get() will throw an exception in the case that mounting an image fails.
|
Hi @jyoo980! |
|
Hi @fvarrui! The Optional class is really annoying to use; and there are a lot of gotchas that can be difficult to catch. If you're interested in automated tools to help you catch bugs like these or more, I've been using the Checker Framework, which helps find bugs like these at compile-time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch that prevents a run-time exception when mounting an image fails when a
.dmgfile is generated.