Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solve annotation element types in AnnotationDeclarationContext #2520

Merged

Conversation

@iTakeshi
Copy link
Contributor

iTakeshi commented Feb 10, 2020

Currently JavaParserAnnotationMemberDeclaration.getType() throws an UnsupportedOperationException, but it should return the corresponding type for the member.
Also, its type should be resolved in the enclosing @interface, which could have nested classes/interfaces/enums, thus I created javaparsermodel.contexts.AnnotationDeclarationContext.

@iTakeshi iTakeshi force-pushed the iTakeshi:symbolsolver-annotation-context branch from 3f98c2f to f000718 Feb 12, 2020
@iTakeshi

This comment has been minimized.

Copy link
Contributor Author

iTakeshi commented Feb 12, 2020

@MysterAitch Thank you very much for your review, and I'm sorry for a couple of my careless misses.
Fixed the author name and rebased to the latest master, then force-pushed (because I don't want to pollute log).

@matozoid

This comment has been minimized.

Copy link
Member

matozoid commented Feb 12, 2020

Thank you both! I'll merge this.

@matozoid matozoid merged commit 3e4ca2c into javaparser:master Feb 12, 2020
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 64.373%
Details
@matozoid matozoid added this to the next release milestone Feb 12, 2020
@iTakeshi iTakeshi deleted the iTakeshi:symbolsolver-annotation-context branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.