New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info 鈩癸笍 and debug 馃悰topics #1

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@wojtkowiak

wojtkowiak commented Oct 16, 2018

Hey,

would you consider adding this?
It would be better to pass the topics to Logger constructor. I wanted to do a PR for it, but realized that I need to somehow pass it to studio-log-format and I am not sure what would be the correct way.

@mantoni

This comment has been minimized.

Member

mantoni commented Oct 16, 2018

Thanks for the pull request. I鈥檓 not against adding topics. However, the emoji for debug is already used for issue.

The other thing is that I鈥榙 prefer to only have topics that say something about what is being logged. The typical info and debug levels are pretty neutral and can be used for anything. This is fine for loggers with severity levels to enable or disable logs for a specific level. This is explicitly avoided by design in this logger implementation.

Again, if you have some other topics that you鈥榙 like to have, I鈥榤 happy to merge a PR.

@wojtkowiak

This comment has been minimized.

wojtkowiak commented Oct 17, 2018

Ok, I agree. I can use issue for debug things and yeah info pretty much can be anything. So that's fine.
I will definitely need to add some more topics as the project grows, so maybe if you have moment it would be good to think about a way of adding topics through configuration. Like I said I already did that for the logger but when I have node j.js | emojilog there is no way passing that further to emojilog or at least a non-hacky way.

@mantoni

This comment has been minimized.

Member

mantoni commented Oct 19, 2018

I think making topics configurable might cause quite some inconveniences when using the logger, especially when invoking emojilog. You would have to introduce a way to specify a configuration file and always pass it on invocation.

If you鈥檙e willing to go down that road, I鈥榣l support you. Alternatively we can add more topics here. I鈥檓 happy to merge pull requests with additional topics here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment