-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Event loop: microtasks and macrotasks #3303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Event loop: microtasks and macrotasks #3303
Conversation
@@ -42,15 +42,15 @@ So far, quite simple, right? | |||
|
|||
Two more details: | |||
1. Rendering never happens while the engine executes a task. It doesn't matter if the task takes a long time. Changes to the DOM are painted only after the task is complete. | |||
2. If a task takes too long, the browser can't do other tasks, such as processing user events. So after a time, it raises an alert like "Page Unresponsive", suggesting killing the task with the whole page. That happens when there are a lot of complex calculations or a programming error leading to an infinite loop. | |||
2. If a task takes too long, the browser can't do other tasks, such as processing user events. So after a time, it raises an alert like "Page Unresponsive", suggesting killing the task with the whole page. That happens when a lot of complex calculations take place or when a programming error leads to an infinite loop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning
I'm non native
maybe
2. If a task takes too long, the browser can't do other tasks, such as processing user events. So after a time, it raises an alert like "Page Unresponsive", suggesting killing the task with the whole page. That happens when a lot of complex calculations take place or when a programming error leads to an infinite loop. | |
2. If a task takes too long, the browser can't do other tasks, such as processing user events. So after a time, it raises a "Page Unresponsive" alert, suggesting to kill the task along the whole page. That happens when a lot of complex calculations take place or when a programming error leads to an infinite loop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about the task along with the whole page
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check commit c0d6a3f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont like "with" there.
"coffee with sugar"
"along" (HOPING Im ok) is "extending to", like
"you kill the task, and the whole page with it"
mmm...
this can be an option too ..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I THINK it s not legibility but grammar
like "leads" instead of "leading"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About along with
It can be used to mean:
- together with
- in addition to
this can be an option too
Yeah there are more ways to describe the same thing suggesting to kill the task and the whole page with it.
could also work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YES
my bad, I got it wrong.
I thought you were asking why "along"
but you were actually fixing it "along with"
Looks ok now I guess...
...
well, if Ilya likes the whole thing.
taking the PR comments into account
the engine? |
I'm thinking that the engine interprets the code. |
hard to explain... |
Made a few minor improvements in grammar here and there:
line 45: the update potentially improves legibility
line 53: added
the engine
to be more conciseline 263: removed
,
because it was placed beforeand
line 323: added missing
: