Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixins #189

Merged
merged 10 commits into from
Jan 10, 2022
Merged

Mixins #189

merged 10 commits into from
Jan 10, 2022

Conversation

mahdiHash
Copy link
Contributor

Please review and comment/commit if anything is wrong.

@mahdiHash
Translate a part of article
fcefb3a 
Line 7 needs more attention
@mahdiHash
Translate a part of article
165c8cb 
Line 19 needs more attention.
@mahdiHash
Translate a part of article
68ed640 
Line 115, 127 and 139 need more attention.
@mahdiHash
Translate a part of article
89171eb 
Line 168 needs more attention.
@mahdiHash
Translate article
3ab3926 
Line 206 needs more attention.
@mahdiHash
Translate comments of "head.html"
be0c46a
@mahdiHash
Merge branch 'javascript-tutorial:master' into master
172f3e3
@javascript-translate-bot javascript-translate-bot requested a review from a team January 8, 2022 13:31
@javascript-translate-bot javascript-translate-bot mentioned this pull request Jan 8, 2022
Open
@mahdiHash mahdiHash marked this pull request as ready for review January 8, 2022 13:36
mahdyar
mahdyar approved these changes Jan 9, 2022
View reviewed changes
Copy link
Member

@mahdyar mahdyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the suggested change(s) and request for another review.

mahdyar
mahdyar requested changes Jan 9, 2022
View reviewed changes
Copy link
Member

@mahdyar mahdyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the suggested change(s) and request for another review.

@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@mahdiHash
Apply suggestions from code review
c4e040e 
Co-authored by: Mahdyar Hasanpour <thisismahdyar@gmail.com>
@mahdiHash
Change a line
89b3ec1 
Co-authored by: Mahdyar Hasanpour <thisismahdyar@gmail.com>
@mahdiHash
Change a line
f3b1569 
Co-authored by: @Beroozam
@mahdiHash
Copy link
Contributor Author

mahdiHash commented Jan 10, 2022 •
edited
Loading

Thanks for your reviews @mahdyar @Beroozam
/done

@javascript-translate-bot javascript-translate-bot requested a review from a team January 10, 2022 09:28
mahdyar
mahdyar approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@mahdyar mahdyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mahdyar mahdyar merged commit c6eeb0a into javascript-tutorial:master Jan 10, 2022
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Beroozam Beroozam Beroozam left review comments

@mahdyar mahdyar mahdyar approved these changes

Assignees
No one assigned
Labels
needs +1 review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mahdiHash @javascript-translate-bot @mahdyar @Beroozam