Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode: flag "u" and class \p{...} #253

Merged
merged 8 commits into from
Feb 1, 2023

Conversation

EhsanShahbazii
Copy link
Contributor

/done

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@mahdiHash mahdiHash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the changes.
You can add the suggestions to a batch and submit a single commit (docs).

9-regular-expressions/03-regexp-unicode/article.md Outdated Show resolved Hide resolved
9-regular-expressions/03-regexp-unicode/article.md Outdated Show resolved Hide resolved
9-regular-expressions/03-regexp-unicode/article.md Outdated Show resolved Hide resolved
9-regular-expressions/03-regexp-unicode/article.md Outdated Show resolved Hide resolved
9-regular-expressions/03-regexp-unicode/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@EhsanShahbazii
Copy link
Contributor Author

/done

@mahdiHash
Copy link
Contributor

Thanks for your contribution, @EhsanShahbazii.

@mahdiHash mahdiHash merged commit 5b03f80 into javascript-tutorial:master Feb 1, 2023
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants