Skip to content

Conversation

@jonnathan-ls
Copy link
Contributor

@jonnathan-ls jonnathan-ls commented Jun 11, 2022

Developer console

πŸ“ Goal

Article update

β˜‘ What was done?

  • Remaining translation of pending text
  • Updating images according to the pt language
  • Fixed broken links

@javascript-translate-bot

Error: the article already translated in the Progress Issue #1 ⁉️

@CLAassistant
Copy link

CLAassistant commented Jun 11, 2022

CLA assistant check
All committers have signed the CLA.

@jonnathan-ls jonnathan-ls force-pushed the fix/started-devtools branch from 49105d0 to d1db525 Compare June 11, 2022 00:36
@jonnathan-ls
Copy link
Contributor Author

jonnathan-ls commented Jun 11, 2022

Error: the article already translated in the Progress Issue #1 ⁉️
#241 (comment) javascript-translate-bot

There is still text that has not been translated.

@odsantos
Copy link
Contributor

Error: the article already translated in the Progress Issue #1 interrobang
#241 (comment) javascript-translate-bot

There is still text that has not been translated.

Hi,

Do you intend to translate what is missing?
It would be helpful to review complete lessons.

Thanks, Osvaldo.

@nazarepiedady
Copy link
Member

@peruibeloko, could you help to make this pull request to walk forward?

@nazarepiedady
Copy link
Member

@jonnathan-ls, do you have some time to review this pull request?

@nazarepiedady nazarepiedady requested review from a team and odsantos February 29, 2024 12:45
@nazarepiedady
Copy link
Member

@jonnathan-ls, could you fix the conflicts to approve the pull request?

@jonnathan-ls jonnathan-ls force-pushed the fix/started-devtools branch from d1db525 to 98b5685 Compare March 17, 2024 17:41
@jonnathan-ls
Copy link
Contributor Author

/done

Copy link
Member

@nazarepiedady nazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good to be applied.

Copy link
Contributor Author

@jonnathan-ls jonnathan-ls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering that this PR is about simple adjustments (grammatical correction and addition of pending translation), with the approval of two reviewers @peruibeloko and @nazarepiedady, I am accepting this PR to apply the update.

@jonnathan-ls jonnathan-ls merged commit fb485ab into javascript-tutorial:master Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants