-
Notifications
You must be signed in to change notification settings - Fork 111
Interaction: alert, prompt, confirm #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interaction: alert, prompt, confirm #244
Conversation
|
Error: the article already translated in the Progress Issue #1 |
There are spelling and syntax errors in our language |
odsantos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, fell free to tell where you disagree. Thanks, Osvaldo.
|
Please make the requested changes. After it, add a comment "/done". |
|
@jonnathan-ls, could you update this pull request? |
/done @nazarepiedady |
nazarepiedady
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonnathan-ls, you could defend your choices of translations when you believe that the approach you took can improve the comprehension of the content.
Now, about this pull request, I think it is good to be approved.
I hope to finish the translation of this content even this year and start the editing this year.
|
@peruibeloko, we know that you are not a maintainer, but your collaboration has been so pertinent that, to me, it is like you are a maintainer. Could you review this pull request? |
|
Considering that this PR is about grammatical correction (simple changes), and with the addition of two approvals @peruibeloko and @nazarepiedady, plus the fix that applied as per @odsantos' review, I am accepting the merge of this PR to apply the update. |
Interaction: alert, prompt, confirm
π Goal
β What was done?