Skip to content

Conversation

@jonnathan-ls
Copy link
Contributor

Interaction: alert, prompt, confirm

πŸ“ Goal

Article update

β˜‘ What was done?

  • fixed misspellings of article about alert, prompt, confirm

@javascript-translate-bot

Error: the article already translated in the Progress Issue #1 ⁉️

@jonnathan-ls
Copy link
Contributor Author

Error: the article already translated in the Progress Issue #1 ⁉️
#244 (comment) javascript-translate-bot

There are spelling and syntax errors in our language

Copy link
Contributor

@odsantos odsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, fell free to tell where you disagree. Thanks, Osvaldo.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review πŸ‘»

@nazarepiedady
Copy link
Member

@jonnathan-ls, could you update this pull request?

@jonnathan-ls jonnathan-ls requested a review from odsantos April 7, 2024 20:25
@jonnathan-ls
Copy link
Contributor Author

... could you update this pull request?

/done @nazarepiedady

Copy link
Member

@nazarepiedady nazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonnathan-ls, you could defend your choices of translations when you believe that the approach you took can improve the comprehension of the content.

Now, about this pull request, I think it is good to be approved.

I hope to finish the translation of this content even this year and start the editing this year.

@nazarepiedady
Copy link
Member

@peruibeloko, we know that you are not a maintainer, but your collaboration has been so pertinent that, to me, it is like you are a maintainer.

Could you review this pull request?

@jonnathan-ls
Copy link
Contributor Author

jonnathan-ls commented Apr 14, 2024

Considering that this PR is about grammatical correction (simple changes), and with the addition of two approvals @peruibeloko and @nazarepiedady, plus the fix that applied as per @odsantos' review, I am accepting the merge of this PR to apply the update.

@jonnathan-ls jonnathan-ls merged commit ed829db into javascript-tutorial:master Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants