New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatted footer, added bootstrap and links (github, code of conduct and contributor links) Closes #123 #128

Merged
merged 4 commits into from Jun 17, 2016

Conversation

Projects
None yet
3 participants
@housseindjirdeh
Contributor

housseindjirdeh commented Jun 17, 2016

Closes #123

@kentcdodds

This comment has been minimized.

Member

kentcdodds commented Jun 17, 2016

Awesome @hdjirdeh. I'm looking forward to looking at this more closely.

I must apologize that I didn't make one thing very clear. I mentioned that we don't have a grid system like bootstrap for the site, but I didn't explain that I don't want to add it either. I want to keep the sight as lightweight as possible (hence generating it in the build and serving static files via a CDN). The payload for each page is pretty small.

Is there any way that you could implement this using flexbox?

@housseindjirdeh

This comment has been minimized.

Contributor

housseindjirdeh commented Jun 17, 2016

Ah sorry about that, for some reason I thought you mentioned to use bootstrap.

Yeah for sure I'll change it up and try to use flexbox instead 👍

@kentcdodds

This comment has been minimized.

Member

kentcdodds commented Jun 17, 2016

Thanks! And again, sorry about that.

Also, you may want to rebase your branch onto master. I just pushed a bunch of changes. Here's a good way to keep your local copy in sync with the original repo: https://egghead.io/lessons/javascript-how-to-fork-and-clone-a-github-repository?course=how-to-contribute-to-an-open-source-project-on-github

@housseindjirdeh

This comment has been minimized.

Contributor

housseindjirdeh commented Jun 17, 2016

No worries at all, and thanks for the video! Yeah I'll rebase my branch more often (noticed there was a conflict too)

I'll update this PR by tomorrow :)

@housseindjirdeh

This comment has been minimized.

Contributor

housseindjirdeh commented Jun 17, 2016

@kentcdodds : fixed, take a look whenever you get the chance and let me know if I should change anything 👍

@kentcdodds

This comment has been minimized.

Member

kentcdodds commented Jun 17, 2016

Could you take a few quick screenshots of the different sizes and put them in here?

@kentcdodds

This comment has been minimized.

Member

kentcdodds commented Jun 17, 2016

Code looks great!

@housseindjirdeh

This comment has been minimized.

Contributor

housseindjirdeh commented Jun 17, 2016

Sure thing, and thanks man appreciate it :)

@housseindjirdeh

This comment has been minimized.

Contributor

housseindjirdeh commented Jun 17, 2016

Laptop:
laptop

@housseindjirdeh

This comment has been minimized.

Contributor

housseindjirdeh commented Jun 17, 2016

Mid-size:
tablet

Mobile:
mobile

@kentcdodds

This comment has been minimized.

Member

kentcdodds commented Jun 17, 2016

Wow, this is perfect! Thanks!

@kentcdodds kentcdodds merged commit 6a161ec into javascriptair:master Jun 17, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@housseindjirdeh

This comment has been minimized.

Contributor

housseindjirdeh commented Jun 17, 2016

@kentcdodds Literally just stumbled on this article that you wrote a while back https://medium.com/@kentcdodds/how-getting-into-open-source-has-been-awesome-for-me-8480cd756a80#.owygt372l

Drawing parallels here but this was my first contribution to OSS, so thanks for all the help buddy 😄

@kentcdodds

This comment has been minimized.

Member

kentcdodds commented Jun 17, 2016

That's awesome! And you're on the contributors page now! Welcome to the wonderful world of OSS!!! 🎉

@bookercodes

This comment has been minimized.

Contributor

bookercodes commented Jun 17, 2016

Awesome work, @hdjirdeh!

💎 Welcome to OSS 💎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment