Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Formatted footer, added bootstrap and links (github, code of conduct and contributor links) Closes #123 #128

Merged

Conversation

housseindjirdeh
Copy link
Contributor

Closes #123

@kentcdodds
Copy link
Member

Awesome @hdjirdeh. I'm looking forward to looking at this more closely.

I must apologize that I didn't make one thing very clear. I mentioned that we don't have a grid system like bootstrap for the site, but I didn't explain that I don't want to add it either. I want to keep the sight as lightweight as possible (hence generating it in the build and serving static files via a CDN). The payload for each page is pretty small.

Is there any way that you could implement this using flexbox?

@housseindjirdeh
Copy link
Contributor Author

Ah sorry about that, for some reason I thought you mentioned to use bootstrap.

Yeah for sure I'll change it up and try to use flexbox instead 👍

@kentcdodds
Copy link
Member

Thanks! And again, sorry about that.

Also, you may want to rebase your branch onto master. I just pushed a bunch of changes. Here's a good way to keep your local copy in sync with the original repo: https://egghead.io/lessons/javascript-how-to-fork-and-clone-a-github-repository?course=how-to-contribute-to-an-open-source-project-on-github

@housseindjirdeh
Copy link
Contributor Author

No worries at all, and thanks for the video! Yeah I'll rebase my branch more often (noticed there was a conflict too)

I'll update this PR by tomorrow :)

@housseindjirdeh
Copy link
Contributor Author

@kentcdodds : fixed, take a look whenever you get the chance and let me know if I should change anything 👍

@kentcdodds
Copy link
Member

Could you take a few quick screenshots of the different sizes and put them in here?

@kentcdodds
Copy link
Member

Code looks great!

@housseindjirdeh
Copy link
Contributor Author

Sure thing, and thanks man appreciate it :)

@housseindjirdeh
Copy link
Contributor Author

Laptop:
laptop

@housseindjirdeh
Copy link
Contributor Author

Mid-size:
tablet

Mobile:
mobile

@kentcdodds
Copy link
Member

Wow, this is perfect! Thanks!

@kentcdodds kentcdodds merged commit 6a161ec into javascriptair:master Jun 17, 2016
@housseindjirdeh
Copy link
Contributor Author

@kentcdodds Literally just stumbled on this article that you wrote a while back https://medium.com/@kentcdodds/how-getting-into-open-source-has-been-awesome-for-me-8480cd756a80#.owygt372l

Drawing parallels here but this was my first contribution to OSS, so thanks for all the help buddy 😄

@kentcdodds
Copy link
Member

That's awesome! And you're on the contributors page now! Welcome to the wonderful world of OSS!!! 🎉

@bookercodes
Copy link
Contributor

Awesome work, @hdjirdeh!

💎 ✨ Welcome to OSS ✨ 💎

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants