Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect type definition for Dataframe.ctypes #198

Closed
jpkli opened this issue May 7, 2021 · 1 comment · Fixed by #211
Closed

Incorrect type definition for Dataframe.ctypes #198

jpkli opened this issue May 7, 2021 · 1 comment · Fixed by #211

Comments

@jpkli
Copy link

jpkli commented May 7, 2021

Docs said Dataframe.ctypes is Series - https://danfo.jsdata.org/api-reference/dataframe/dataframe.dtypes

But type definition is "any []" - https://github.com/opensource9ja/danfojs/blob/master/danfojs-node/types/core/frame.d.ts#L337

It's returning as Series in the source - https://github.com/opensource9ja/danfojs/blob/eb5919d2cac34271fc3b725fa24aa3ad4eacde37/danfojs/src/core/frame.js#L1848

Should the type definition be fixed?

Thank you!

@risenW
Copy link
Member

risenW commented May 30, 2021

FIXED in #211

risenW added a commit that referenced this issue May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants