Skip to content

Version 1.1.1 published to NPM does not match release 1.1.1 in GitHub #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ptohara14 opened this issue Jun 20, 2022 · 0 comments
Open
Assignees

Comments

@ptohara14
Copy link

The published package for danfojs-node 1.1.1 on NPM registry does not match the version 1.1.1 release in this GitHub repository.
Specifically it does not contain #441.
The version numbers look correct in NPM however the contents of the package are not.

To Reproduce

  1. npm install danfojs-node@1.1.1
  2. cat package.json
    "danfojs-node": "^1.1.1",
  3. less node_modules/danfsjs-node/dist/danfojs-base/core/frame.js
    Function DataFrame.prototype.fillNa = function (values, options) {
    ....
    if (!values && typeof values !== "boolean" && typeof values !== "number") {
    ....
  4. wget https://registry.npmjs.org/danfojs-node/-/danfojs-node-1.1.1.tgz
  5. tar xvzf danfojs-node-1.1.1.tgz
  6. less package/dist/danfojs-base/core/frame.js
    ....
    if (!values && typeof values !== "boolean" && typeof values !== "number") {
    ....

Expected behavior
frame.js expected to contain:
Function DataFrame.prototype.fillNa = function (values, options) {
....
if (!values && typeof values !== "boolean" && typeof values !== "number" && typeof values !== "string") {
....

Environment:

  • OS: Rockey Linux 8
  • Runtime: Node v14.19.2
  • NPM version: 6.14.17
@risenW risenW self-assigned this Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants