New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@FacesConverter(managed=true) on Converter<SuperClass> broken #4324

Closed
BalusC opened this Issue Jan 21, 2018 · 2 comments

Comments

Projects
None yet
1 participant
@BalusC
Collaborator

BalusC commented Jan 21, 2018

com.sun.faces.cdi.CdiUtils#createConverter() must retry finding CDI converter by forClass.getSuperClass() until non-null is returned.

Real world scenario:

public class Product extends BaseEntity {}
@FacesConverter(forClass=BaseEntity.class, managed=true)
public class BaseEntityConverter implements Converter<BaseEntity> {}

This is successfully resolved as JSF converter but not as CDI converter.

@BalusC

This comment has been minimized.

Collaborator

BalusC commented Jan 28, 2018

To do: add unit test.

BalusC added a commit that referenced this issue Feb 11, 2018

@BalusC

This comment has been minimized.

Collaborator

BalusC commented Feb 11, 2018

IT has been added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment