Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getPublicUrl(), getPrivateUrl() and getUrl() #21

Closed
robert-bor opened this issue Apr 28, 2013 · 0 comments
Closed

getPublicUrl(), getPrivateUrl() and getUrl() #21

robert-bor opened this issue Apr 28, 2013 · 0 comments
Assignees
Labels
Milestone

Comments

@robert-bor
Copy link
Contributor

@robert-bor robert-bor commented Apr 28, 2013

Currently, JOSS has Object.getPublicUrl(), which constructs a URL for an object. If the host is set, it will use this (pretty) host, else it will use the (non-pretty) ObjectStore URL.

JOSS must support the following:

  • getPublicUrl(); uses publicHost or else ObjectStore URL
  • getPrivateUrl(); uses privateHost or else ObjectStore URL
  • getUrl(); uses privateHost if the container is private and privateHost is set, else publicHost (if set), else ObjectStore URL

AccountConfig will change:

  • remove host
  • add publicHost
  • add privateHost

Considered keeping host for backwards compatibility reasons, but rejected.

@ghost ghost assigned robert-bor Apr 28, 2013
@robert-bor robert-bor closed this Apr 28, 2013
robert-bor added a commit that referenced this issue Apr 28, 2013
robert-bor added a commit that referenced this issue Apr 28, 2013
…er privacy whether to use the public or the private host
robert-bor added a commit that referenced this issue Apr 28, 2013
katta pushed a commit to twxkit/joss that referenced this issue Oct 6, 2014
katta pushed a commit to twxkit/joss that referenced this issue Oct 6, 2014
…e container privacy whether to use the public or the private host
katta pushed a commit to twxkit/joss that referenced this issue Oct 6, 2014
katta pushed a commit to twxkit/joss that referenced this issue Oct 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.