New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added delimiters to container list #54

Merged
merged 1 commit into from Mar 11, 2014

Conversation

Projects
None yet
5 participants
@philborlin
Contributor

philborlin commented Mar 7, 2014

The Swift Documentation uses prefix and delimiter to allow the access of pseudo-directories. Swift already supports prefixes. This pull request adds delimiters to the container list() method.

@buildhive

This comment has been minimized.

Show comment
Hide comment
@buildhive

buildhive Mar 7, 2014

Java Swift » joss #51 SUCCESS
This pull request looks good
(what's this?)

buildhive commented Mar 7, 2014

Java Swift » joss #51 SUCCESS
This pull request looks good
(what's this?)

robert-bor added a commit that referenced this pull request Mar 11, 2014

Merge pull request #54 from philborlin/master
Added delimiters to container list

@robert-bor robert-bor merged commit 021ffae into javaswift:master Mar 11, 2014

@robert-bor

This comment has been minimized.

Show comment
Hide comment
@robert-bor

robert-bor Mar 16, 2014

Member

Thanks, Phil! There's a bit more work involved to get this right, though. For example, one can get back these JSON array entries:

[
   {"subdir": "/abc/def/"}, 
   {"subdir": "/abc/deg/"}, 
   {"hash": "5289df737df57326fcdd22597afb1fac", "last_modified": "2014-03-16T21:46:48.452870", "bytes": 3, "name": "/abc/ijk.bin", "content_type": "application/octet-stream"}
]

I'll make the necessary changes to get this working.

Member

robert-bor commented Mar 16, 2014

Thanks, Phil! There's a bit more work involved to get this right, though. For example, one can get back these JSON array entries:

[
   {"subdir": "/abc/def/"}, 
   {"subdir": "/abc/deg/"}, 
   {"hash": "5289df737df57326fcdd22597afb1fac", "last_modified": "2014-03-16T21:46:48.452870", "bytes": 3, "name": "/abc/ijk.bin", "content_type": "application/octet-stream"}
]

I'll make the necessary changes to get this working.

@robert-bor robert-bor added this to the 0.9.5 milestone Mar 27, 2014

@robert-bor robert-bor self-assigned this Mar 27, 2014

robert-bor added a commit that referenced this pull request Mar 28, 2014

Issue #54 added basic structure for reading directories/objects from …
…a file after passing a delimiter. Still need to add unit tests, a mock implementation, a configurable delimiter and the bare name (excluding path) for directories/objects

robert-bor added a commit that referenced this pull request Mar 28, 2014

Issue #54 included bare names for StoredObject and Directories. Bare …
…names are names that are stripped of all path information

robert-bor added a commit that referenced this pull request Mar 28, 2014

robert-bor added a commit that referenced this pull request Mar 28, 2014

robert-bor added a commit that referenced this pull request Mar 28, 2014

robert-bor added a commit that referenced this pull request Mar 28, 2014

robert-bor added a commit that referenced this pull request Mar 28, 2014

Issue #54 extended mock Swift with functionality to emulate delimiter…
… behaviour (ie, searching pseudo-hierarchies as if they were directories)

robert-bor added a commit that referenced this pull request Mar 28, 2014

@robert-bor

This comment has been minimized.

Show comment
Hide comment
@robert-bor

robert-bor Mar 28, 2014

Member

Phil, the solution now looks as follows. On Container, you can call listDirectory. It will pass a delimiter, which is by default a slash ('/'), but you can configure it to be something else (heaven knows why you would want that, but still it's an option).

I will release the new functionality in v0.9.5

Member

robert-bor commented Mar 28, 2014

Phil, the solution now looks as follows. On Container, you can call listDirectory. It will pass a delimiter, which is by default a slash ('/'), but you can configure it to be something else (heaven knows why you would want that, but still it's an option).

I will release the new functionality in v0.9.5

@jeacott

This comment has been minimized.

Show comment
Hide comment
@jeacott

jeacott Jun 10, 2014

Can I just clarify that this now enables the functionality here?:
Pseudo-hierarchies (to emulate directory structures) -> specifically, example 4.36/4.37 (path and delimiter) in http://docs.openstack.org/api/openstack-object-storage/1.0/content/folders-directories.html

this is still listed in the Future features page, so I'm a bit confused.

thanks.

jeacott commented Jun 10, 2014

Can I just clarify that this now enables the functionality here?:
Pseudo-hierarchies (to emulate directory structures) -> specifically, example 4.36/4.37 (path and delimiter) in http://docs.openstack.org/api/openstack-object-storage/1.0/content/folders-directories.html

this is still listed in the Future features page, so I'm a bit confused.

thanks.

@roikku

This comment has been minimized.

Show comment
Hide comment
@roikku

roikku Jun 12, 2014

Member

Hi jeacott,

Yes, this functionality has been implemented since version 0.9.5.

Member

roikku commented Jun 12, 2014

Hi jeacott,

Yes, this functionality has been implemented since version 0.9.5.

katta pushed a commit to twxkit/joss that referenced this pull request Oct 6, 2014

Merge pull request #54 from philborlin/master
Added delimiters to container list

katta pushed a commit to twxkit/joss that referenced this pull request Oct 6, 2014

Issue #54 added basic structure for reading directories/objects from …
…a file after passing a delimiter. Still need to add unit tests, a mock implementation, a configurable delimiter and the bare name (excluding path) for directories/objects

katta pushed a commit to twxkit/joss that referenced this pull request Oct 6, 2014

Issue #54 included bare names for StoredObject and Directories. Bare …
…names are names that are stripped of all path information

katta pushed a commit to twxkit/joss that referenced this pull request Oct 6, 2014

katta pushed a commit to twxkit/joss that referenced this pull request Oct 6, 2014

katta pushed a commit to twxkit/joss that referenced this pull request Oct 6, 2014

katta pushed a commit to twxkit/joss that referenced this pull request Oct 6, 2014

katta pushed a commit to twxkit/joss that referenced this pull request Oct 6, 2014

Issue #54 extended mock Swift with functionality to emulate delimiter…
… behaviour (ie, searching pseudo-hierarchies as if they were directories)

katta pushed a commit to twxkit/joss that referenced this pull request Oct 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment