Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes in affectedCdo from version 6.0.0 #1130

Closed
velinovskav opened this issue Aug 18, 2021 · 5 comments
Closed

Changes in affectedCdo from version 6.0.0 #1130

velinovskav opened this issue Aug 18, 2021 · 5 comments
Labels
bug fixed

Comments

@velinovskav
Copy link

velinovskav commented Aug 18, 2021 •
edited

Hello,

I am using Javers 5.15.0 version on production environment and want to do updade to 6.2.3 version.
During the update I noticed that there was a change in the affectedCdo (commit: 5d508a9)
image

Is there any reason why affectedCdo was changed from right to left (first) because I haven't find any description about this change in release notes / commit message?

Thanks
trajchen pushed a commit to trajchen/javers that referenced this issue Aug 19, 2021
@trajchenaumoski
Revert affectedCdo from left to right object
41d530a 
According to the reported issue 1130, affectedCdo was
changed from right to left in version 6.0.0. By this
commit the library will be compatible with 5.x
implementations.

Link:
javers#1130
@bartoszwalacik
Copy link
Member

Yes, I had a good reason which I can explain, but I wonder why you care about this change? This code is internal and this change shouldn't affect your code.

@velinovskav
Copy link
Author

We are using Change#getAffectedObject which is public and with this change affected object has been changed. Instead of right object, we are getting left object.

@bartoszwalacik
Copy link
Member

You are right, the javadoc suggests that it should be the right object :)

@bartoszwalacik
Copy link
Member

Please create a PR with the fix, I will merge

bartoszwalacik added a commit that referenced this issue Sep 4, 2021
@bartoszwalacik
https://github.com/javers/javers/issues/1130
e1a7dba 
Change#getAffectedObject fix
bartoszwalacik added a commit that referenced this issue Sep 4, 2021
@bartoszwalacik
Merge pull request #1141 from javers/getRight_fix
3753019 
#1130
@bartoszwalacik
Copy link
Member

fixed in 6.2.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bartoszwalacik @velinovskav