Various issues using Javers on oracle in springboot and oracle synonym as well as reserved words

[vahidhedayati]

I have noticed quite a few major issues which stops javers from working properly on oracle. It will probably now remain disabled until there are fixes.

1. Whilst you can define in properties / yml file the following overrides for table names:

javers.sqlCommitTableName=t_jv_commit
javers.sqlGlobalIdTableName=t_jv_global_id
javers.sqlCommitPropertyTableName=t_jv_commit_property
javers.sqlSnapshotTableName=t_jv_snapshot

Notice the t_ pre the table names, in our work place oracle instances are not configured / accessible for users to interact with directly instead their wrapped with a synonym and assuming they now start with t_
This part works well until a record is inserted, then the underlying process to find next id refers to the raw table name.
In our case only synonym names are available for tables and sequences and therefore the sequence should also start with t_ or whatever our synonym declaration is.

There was something raised about tables and reserved words of type and version but think they were initiallly created with quotes that caused all the issues having recreated table using process it seems to work

[bartoszwalacik]

Hi @vahidhedayati , not sure what is this issue about, I need a feature in Javers to allow custom names for sequences?

[vahidhedayati]

@bartoszwalacik sorry for the late reply, yes I think there needs to be a way to declare what the squence table names should be or it should use the customised table names declared as part of the config when it comes to getting next id. It seems to. I think there are various places impacted by it the javers-persistence-sql/session/Dialects and think also within the insert as it builds query there seems to be some sql such as:

insert into t_jv_snapshop (type,global_id_fk_commit_fk, version,state,change_properties,managed_type,snapshot_pk) values(?,?,?,?,?,?,?,jv_snapshot_pk_seq.nextval * 100)

that managed_type,snapshot_pk is mapping to raw table name sequnce definition jv_snapshot_pk_seq

ideally a way of overriding all sequence definitions would work best,

[bartoszwalacik]

Hi, if you just need a feture to configure custom seq names , I'm ok with that. Consider contributing a PR

[bartoszwalacik]

fixed, released in 7.8.4

[bartoszwalacik]

thanks @vahidhedayati