New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: compare lists #177

Closed
tchegito opened this Issue Jul 7, 2015 · 5 comments

Comments

Projects
None yet
4 participants
@tchegito

tchegito commented Jul 7, 2015

Following previous issue ( #176 ), here is

When we compare directly collections with Javers, content type can't be determined at runtime.
So a way to achieve this would be this method signature:

compareCollections(Object left, Object right, Class itemType)

Then we could take advantage of Javers entities, and get a complete comparison, as if we provided a container with such list.

@pszymczyk pszymczyk self-assigned this Jul 8, 2015

@bartoszwalacik bartoszwalacik added this to the release 1.3.9 milestone Sep 21, 2015

@kalarani

This comment has been minimized.

kalarani commented Oct 21, 2015

+1
Right now i'm working around this by using a Wrapper class, which has no business value, and is required only for the purpose of comparison. It would be great if we can just compare two collections like
compare(List<itemType> left, List<itemType> right)
instead of
compare(new Wrapper(left), new Wrapper(right))

@bartoszwalacik

This comment has been minimized.

Member

bartoszwalacik commented Oct 21, 2015

we are working on this issue ... stay tuned

@bartoszwalacik bartoszwalacik added the fixed label Nov 8, 2015

@bartoszwalacik

This comment has been minimized.

Member

bartoszwalacik commented Nov 8, 2015

released in 1.3.20

@bartoszwalacik

This comment has been minimized.

@tchegito

This comment has been minimized.

tchegito commented Nov 9, 2015

Thanks, guys !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment