JaVers objects should be Jackson friendly

[igler]

Serialize JaVers changes List<Change> through Jackson. Snapshots List<CdoSnapshot>already work.

[bartoszwalacik]

today I'll release javers 1.3.9, int this version
exception AFFECTED_CDO_IS_NOT_AVAILABLE JaVers runtime error when serializing Changes to JSON using Jackson is fixed.

Still, JSON output created by Jackson will be very verbose as it simply uses Jackson defaults.
Neat nad consice JSON serialization of JaVers objects can be easily done using JaVers internal JSON mapping engine (based on Gson) - javers.getJsonConverter().toJson(...)

[igler]

Sounds good. I'll stay tuned and let you know how things go.

[bartoszwalacik]

check fresh 1.3.9 release

[igler]

Works perfect! Using the following code JSON-output is nice and smooth:

@RequestMapping(value = "/{id:[0-9]+}" + ChangeLinks.CHANGES, method = RequestMethod.GET)
public ResponseEntity<List<Change>> getChangesOfLocation(@PathVariable("id") Location location) {
        
    List changeList = javers
        .findChanges(QueryBuilder.byInstanceId(location.getId(), PublicLocation.class).build());

BTW, how can I influence how changes on references are rendered in "left" and "right" properties? Does it eventually work with Spring data-projections?

[bartoszwalacik]

well, since you are not using JaVavers to build JSON, it's rather a question to spring-mcv or jackson,
so it's on your side.

That's why I recommend using Javers to building JSON. JaVers creates neat, concise and customizable JSON.

In Spring controller you can do it quite easily:

@RequestMapping(...)
@ResponseBody
public String getChanges() {
    List changeList = javers.findChanges(...);
    return javers.getJsonConverter().toJson(changeList);
}

[igler]

What I meant was adjusting the following output through e.g. a CustomPropertyComparator (http://javers.org/documentation/diff-configuration/):

"left": {
      "cdoId": 2,
      "cdoClass": {
        "clientsClass": "....LocationNetwork",
        "idProperty": {
          "name": "id",
          "type": "java.lang.Long",
          "genericType": "java.lang.Long",
          "hasTransientAnn": false
        }
        ...
   ...

Is it possible to retrieve the name of the LocationNetwork object and place it inside the "left"-property as a string?

[igler]

... did the following:

public class LocationNetworkComparator implements CustomPropertyComparator<LocationNetwork, ValueChange> {
    @Override
    public ValueChange compare(LocationNetwork leftNetwork, LocationNetwork rightNetwork, GlobalId globalId, Property property) {
        String leftNetworkName = leftNetwork.getName();
        String rightNetworkName = rightNetwork.getName();
        return new ValueChange(globalId, property, leftNetworkName, rightNetworkName);
    }
}

... which works when I change a property only (of course as the upper comparator is not involved) or change a reference only. But when I do both in combination it comes to an error when the name of the reference (network) is resolved. In this case leftNetwork and rightNetwork are bot null.

[igler]

OK, got it now. It is important that the comparator code is written the following way when the third situation occurs:

public class LocationNetworkComparator implements CustomPropertyComparator<LocationNetwork, ValueChange> {
    @Override
    public ValueChange compare(LocationNetwork leftNetwork, LocationNetwork rightNetwork, GlobalId globalId, Property property) {
        if(leftNetwork != null && rightNetwork != null && leftNetwork.equals(rightNetwork))
            return null;
        else {
            String leftNetworkName = null;
            String rightNetworkName = null;
            if (leftNetwork != null)
                leftNetworkName = leftNetwork.getName();
            if (rightNetwork != null)
                rightNetworkName = rightNetwork.getName();
            return new ValueChange(globalId, property, leftNetworkName, rightNetworkName);
        }
    }
}

[bartoszwalacik]

Ok, good to hear that CustomComparators works for you

[igler]

You can close this issue if you want to.