ClassCastException with joda-time objects #224
Comments
|
looks similar to #218 |
|
we are working on fixing this |
|
FWIW, unlike the case described there, this one isn't random at all. One DateTime object breaks |
|
If you submit a failing test which isoletes the problem, it would help us to find the bug |
|
fix for #218 is released in fresh version 1.3.14, available at https://oss.sonatype.org/content/repositories/releases/ and in few hours in Maven Central, Could you check if it solves your issue (I think it will) |
|
We have run into the same issue just now. We are still getting the above exception with 1.3.14 |
|
ok, so could you please submit a failing test which isolets this issue? you can push it to your forked Javers repository |
|
Failing test is available in 3a03e1d. It seems that if two DateTimes have different chronologies, it cannot handle it. If both DateTime instances use the same chronology, then it works fine. |
|
chronology ... so when two dates are using diffrent callendars? In fact, there is no out-of-the-box support for org.joda.time.DateTime in JaVers Try to write and register |
|
@szmeti your failing test is fine, I have ClassCastException reproduced on my maschine ... |
|
I mean that lack of support for joda DateTime as ValueType should not result in ClassCastException |
|
found a bug in our |
fixed bug in Optional.equals()
|
bug is fixed in v 1.3.17 |
Hey there,
Trying to use the library on an object containing various jodatime's DateTime fields, I get the following exception:
java.util.concurrent.CompletionException: java.lang.ClassCastException: org.joda.time.chrono.ISOChronology cannot be cast to org.javers.core.metamodel.object.GlobalId at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:273) ~[na:1.8.0_60] at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:280) ~[na:1.8.0_60] at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1592) [na:1.8.0_60] at java.util.concurrent.CompletableFuture$AsyncSupply.exec(CompletableFuture.java:1582) [na:1.8.0_60] at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289) ~[na:1.8.0_60] at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056) ~[na:1.8.0_60] at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692) ~[na:1.8.0_60] at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157) ~[na:1.8.0_60] Caused by: java.lang.ClassCastException: org.joda.time.chrono.ISOChronology cannot be cast to org.javers.core.metamodel.object.GlobalId at org.javers.core.graph.ObjectNode.getReference(ObjectNode.java:75) ~[javers-core-1.3.13.jar:na] at org.javers.core.diff.RealNodePair.getRightGlobalId(RealNodePair.java:61) ~[javers-core-1.3.13.jar:na] at org.javers.core.diff.appenders.ReferenceChangeAppender.calculateChanges(ReferenceChangeAppender.java:25) ~[javers-core-1.3.13.jar:na] at org.javers.core.diff.appenders.ReferenceChangeAppender.calculateChanges(ReferenceChangeAppender.java:15) ~[javers-core-1.3.13.jar:na] at org.javers.core.diff.DiffFactory.appendChanges(DiffFactory.java:142) ~[javers-core-1.3.13.jar:na] at org.javers.core.diff.DiffFactory.appendPropertyChanges(DiffFactory.java:132) ~[javers-core-1.3.13.jar:na] at org.javers.core.diff.DiffFactory.createAndAppendChanges(DiffFactory.java:114) ~[javers-core-1.3.13.jar:na] at org.javers.core.diff.DiffFactory.create(DiffFactory.java:65) ~[javers-core-1.3.13.jar:na] at org.javers.core.diff.DiffFactory.compare(DiffFactory.java:58) ~[javers-core-1.3.13.jar:na] at org.javers.core.JaversCore.compare(JaversCore.java:94) ~[javers-core-1.3.13.jar:na]The text was updated successfully, but these errors were encountered: