Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@TypeName annotation scanner #263

Closed
bartoszwalacik opened this issue Dec 5, 2015 · 6 comments
Closed

@TypeName annotation scanner #263

bartoszwalacik opened this issue Dec 5, 2015 · 6 comments
Labels

Comments

@bartoszwalacik
Copy link
Member

@bartoszwalacik bartoszwalacik commented Dec 5, 2015

As a JaVers user I want to scan all my classes with @typename annotation (in given package)
with one call to JaversBuilder (preferably scanTypeNames(String packageToScan))
in order to use them in all kinds of JQL queries without getting TYPE_NAME_NOT_FOUND exception.

@SInCE 1.4

Vote here if you think that it could be useful.

@bartoszwalacik
Copy link
Member Author

@bartoszwalacik bartoszwalacik commented Sep 2, 2016

@abibell , this is not a good place for copy pasting long code listing, if you have questions about using JaversBuilder.scanTypeName() - ask on http://stackoverflow.com/questions/tagged/javers

@abibell
Copy link
Contributor

@abibell abibell commented Sep 8, 2016

  1. I could bring in ann library and use it for scanTypeNames(). Are you ok with this?
  2. What are your thoughts on using configuration property packageToScan which is baked in the base bean which will scan package if provided. It would not scan if there is no value provided (default). Package scanning maybe fairly common scenario like choice of algorithm and others to be considered for Configuration over customisation.

If we are on same page I could finish and send PR today

@bartoszwalacik
Copy link
Member Author

@bartoszwalacik bartoszwalacik commented Sep 12, 2016

  1. some evaluation is required, maybe you can suggest some lib (there are many) and I will test it. It should be small and fast. We strive to keep javers-core dependencies list short. Maybe we will create a new module (named javers-core-ann-scanner) ?
  2. yes, packageToScan property sounds like a good idea
@bartoszwalacik
Copy link
Member Author

@bartoszwalacik bartoszwalacik commented Sep 12, 2016

@bartoszwalacik
Copy link
Member Author

@bartoszwalacik bartoszwalacik commented Sep 12, 2016

@abibell we could discuss details on javers chat https://gitter.im/javers/javers

@bartoszwalacik
Copy link
Member Author

@bartoszwalacik bartoszwalacik commented Sep 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.