New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JQL - new CommitId filter #309

Closed
bartoszwalacik opened this Issue Jan 18, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@bartoszwalacik
Member

bartoszwalacik commented Jan 18, 2016

Requested by @atomfrede
hipster-labs/generator-jhipster-entity-audit#4

Query by CommitId could be implemended as a new filter, available only for snapshot queries:

javers.findSnapshots( QueryBuilder.byInstanceId("bob", Employee.class).withCommitId(1.0).build() )
@atomfrede

This comment has been minimized.

atomfrede commented Jan 18, 2016

I can try to contribute the new filter if you like.

@bartoszwalacik

This comment has been minimized.

Member

bartoszwalacik commented Jan 18, 2016

We have a team meeting today evening, and we will do some planning. Stay tuned

@atomfrede

This comment has been minimized.

atomfrede commented Jan 18, 2016

Awesome! Thanks for your support!

@mwesolowski mwesolowski self-assigned this Jan 18, 2016

@mwesolowski mwesolowski added in progress and removed ready labels Jan 18, 2016

@bartoszwalacik

This comment has been minimized.

Member

bartoszwalacik commented Jan 19, 2016

@atomfrede, @mwesolowski is going to implement this new filter. Stay tuned

mwesolowski added a commit to mwesolowski/javers that referenced this issue Jan 19, 2016

mwesolowski added a commit to mwesolowski/javers that referenced this issue Jan 19, 2016

mwesolowski added a commit to mwesolowski/javers that referenced this issue Jan 20, 2016

mwesolowski added a commit to mwesolowski/javers that referenced this issue Jan 20, 2016

mwesolowski added a commit to mwesolowski/javers that referenced this issue Jan 20, 2016

javers#309 Commit Id filter
# Please enter the commit message for your changes. Lines starting
# with '#' will be kept; you may remove them yourself if you want to.
# An empty message aborts the commit.
#
# Date:      Mon Jan 18 22:45:36 2016 +0100
#
# On branch 309-commit-id-filter-for-mongo24
# Changes to be committed:
#	modified:   javers-core/src/main/java/org/javers/repository/api/QueryParams.java
#	modified:   javers-core/src/main/java/org/javers/repository/api/QueryParamsBuilder.java
#	modified:   javers-core/src/main/java/org/javers/repository/inmemory/InMemoryRepository.java
#	modified:   javers-core/src/main/java/org/javers/repository/jql/QueryBuilder.java
#	modified:   javers-core/src/test/groovy/org/javers/core/JaversRepositoryE2ETest.groovy
#	modified:   javers-persistence-mongo/src/main/java/org/javers/repository/mongo/MongoRepository.java
#	modified:   javers-persistence-sql/src/main/java/org/javers/repository/sql/finders/CdoSnapshotFinder.java
#	modified:   javers-persistence-sql/src/main/java/org/javers/repository/sql/finders/SnapshotFilter.java
#

mwesolowski added a commit to mwesolowski/javers that referenced this issue Jan 20, 2016

mwesolowski added a commit to mwesolowski/javers that referenced this issue Jan 20, 2016

mwesolowski added a commit to mwesolowski/javers that referenced this issue Jan 20, 2016

@mwesolowski mwesolowski added review and removed in progress labels Jan 20, 2016

bartoszwalacik added a commit that referenced this issue Jan 23, 2016

@bartoszwalacik bartoszwalacik added documentation and removed review labels Jan 23, 2016

@bartoszwalacik

This comment has been minimized.

Member

bartoszwalacik commented Jan 25, 2016

@bartoszwalacik

This comment has been minimized.

Member

bartoszwalacik commented Jan 25, 2016

@atomfrede check new filter by commitId(). This filter makes sense only for snapshot queries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment