New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JQL - new withVersion() filter #322

Closed
bartoszwalacik opened this Issue Jan 26, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@bartoszwalacik
Member

bartoszwalacik commented Jan 26, 2016

new filter for snapshot queries:

javers.findSnapshots( QueryBuilder.byInstanceId("bob", Employee.class).withVersion(5).build() )

withVersion() should work simmilary to withCommitId() filter

requested by:
@atomfrede
@milanov

@bartoszwalacik

This comment has been minimized.

Member

bartoszwalacik commented Jan 26, 2016

It could be implemented in the same way like commitId filter done by @mwesolowski
see https://github.com/javers/javers/pull/318/files

mwesolowski added a commit to mwesolowski/javers that referenced this issue Jan 26, 2016

mwesolowski added a commit to mwesolowski/javers that referenced this issue Jan 26, 2016

@bartoszwalacik

This comment has been minimized.

Member

bartoszwalacik commented Jan 27, 2016

@milanov, looks like @mwesolowski already did it :)

@atomfrede

This comment has been minimized.

atomfrede commented Jan 27, 2016

@bartoszwalacik @mwesolowski Wow, that was fast! Impressive!

bartoszwalacik added a commit that referenced this issue Jan 28, 2016

Merge pull request #323 from mwesolowski/322
#322 JQL - snapshot version filter

@bartoszwalacik bartoszwalacik self-assigned this Jan 28, 2016

@bartoszwalacik

This comment has been minimized.

Member

bartoszwalacik commented Jan 29, 2016

@bartoszwalacik

This comment has been minimized.

Member

bartoszwalacik commented Jan 29, 2016

@atomfrede check out new withVersion() filter, does it solve your issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment