/javers

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JQL - new withVersion() filter #322

Closed
bartoszwalacik opened this Issue Jan 26, 2016 · 5 comments

Comments

Assignees

@bartoszwalacik bartoszwalacik

Labels
Projects
None yet
Milestone
No milestone
2 participants
@bartoszwalacik @atomfrede
@bartoszwalacik
Member

bartoszwalacik commented Jan 26, 2016

new filter for snapshot queries:

javers.findSnapshots( QueryBuilder.byInstanceId("bob", Employee.class).withVersion(5).build() )

withVersion() should work simmilary to withCommitId() filter

requested by:
@atomfrede
@milanov

@bartoszwalacik bartoszwalacik added enhancement labels Jan 26, 2016

@bartoszwalacik

This comment has been minimized.

Sign in to view
Member

bartoszwalacik commented Jan 26, 2016

It could be implemented in the same way like commitId filter done by @mwesolowski
see https://github.com/javers/javers/pull/318/files

@bartoszwalacik bartoszwalacik referenced this issue Jan 26, 2016

Closed

Add javers option #4

mwesolowski added a commit to mwesolowski/javers that referenced this issue Jan 26, 2016

@mwesolowski
javers#322 JQL - snapshot version filter
Loading status checks…
c4c3d43

mwesolowski added a commit to mwesolowski/javers that referenced this issue Jan 26, 2016

@mwesolowski
javers#322 JQL - snapshot version filter
Loading status checks…
7b45dc4
@bartoszwalacik

This comment has been minimized.

Sign in to view
Member

bartoszwalacik commented Jan 27, 2016

@milanov, looks like @mwesolowski already did it :)
@atomfrede

This comment has been minimized.

Sign in to view

atomfrede commented Jan 27, 2016

@bartoszwalacik @mwesolowski Wow, that was fast! Impressive!

bartoszwalacik added a commit that referenced this issue Jan 28, 2016

@bartoszwalacik
Merge pull request #323 from mwesolowski/322 
#322 JQL - snapshot version filter
Loading status checks…
9414af2

@bartoszwalacik bartoszwalacik added the documentation label Jan 28, 2016

@bartoszwalacik bartoszwalacik self-assigned this Jan 28, 2016

@bartoszwalacik

This comment has been minimized.

Sign in to view
Member

bartoszwalacik commented Jan 29, 2016

released in v. 1.4.7
see http://javers.org/documentation/jql-examples/#version-filter

@bartoszwalacik bartoszwalacik closed this Jan 29, 2016

@bartoszwalacik bartoszwalacik added fixed documentation and removed documentation labels Jan 29, 2016

@bartoszwalacik

This comment has been minimized.

Sign in to view
Member

bartoszwalacik commented Jan 29, 2016

@atomfrede check out new withVersion() filter, does it solve your issue?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment