Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Message Enhancement Request #394

Closed
gtnarg opened this issue Jun 22, 2016 · 3 comments
Closed

Error Message Enhancement Request #394

gtnarg opened this issue Jun 22, 2016 · 3 comments
Labels

Comments

@gtnarg
Copy link

@gtnarg gtnarg commented Jun 22, 2016

I am receiving the following error message:

ENTITY_INSTANCE_WITH_NULL_ID Found Entity instance of class 'com.mypackage.MyClass' with null id

The message is correct and I understand what it means because I integrated javers into the application but it could be misleading to someone not familiar with Javers. In the case of the diff where this is occurring I have set the idPropertyName to a different property (i.e. not id) but the message indicates that the "id" is null when it actually isn't. Would it be possible enhance the message with the name of the idPropertyName that is null?

@bartoszwalacik
Copy link
Member

@bartoszwalacik bartoszwalacik commented Jun 23, 2016

Could be, will you contribute a PR? That's easy to do: Entity.java line 96

@gtnarg
Copy link
Author

@gtnarg gtnarg commented Jun 25, 2016

Sure - be happy to :)

bartoszwalacik added a commit that referenced this issue Jul 4, 2016
@bartoszwalacik
Copy link
Member

@bartoszwalacik bartoszwalacik commented Jul 23, 2016

fixed in 2.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants