Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ShallowReference for properties #412

Closed
croffler opened this issue Aug 1, 2016 · 10 comments
Closed

@ShallowReference for properties #412

croffler opened this issue Aug 1, 2016 · 10 comments
Labels

Comments

@croffler
Copy link

@croffler croffler commented Aug 1, 2016

It would be nice if the @ShallowReference annotation could be used on a property.
I have some entities that have a large graph (many relations). In many cases I would like for Javers to just save the ID's of the embedded entities. If I use @Diffignore the relationship info is lost.

@bartoszwalacik
Copy link
Member

@bartoszwalacik bartoszwalacik commented Aug 1, 2016

agreed that it could be useful, unfortunately, implementation would not be easy (ShallowReference is now a JaversType)

@LucasDesenv
Copy link

@LucasDesenv LucasDesenv commented Sep 20, 2016

We need this issue solved to use Javers in our company. Do you guys have plans to solve this one? If so, is there a release date planned?

@bartoszwalacik
Copy link
Member

@bartoszwalacik bartoszwalacik commented Sep 20, 2016

I dont think that anyone from JaVers core team is going to take care about this issue soon

@bartoszwalacik
Copy link
Member

@bartoszwalacik bartoszwalacik commented Sep 20, 2016

You can contribute a PR but i'm affraid that it won't be easy one

@croffler
Copy link
Author

@croffler croffler commented Sep 20, 2016

What I have done for now is to use @Diffignore.

Most of the Entities we have, those properties (associations) can't be
changed once the Entity is created. If we need to get the actual info for
those properties we can retrieve them from the RDBMS.

Chris

On Tue, Sep 20, 2016 at 6:35 PM, Bartosz Walacik notifications@github.com
wrote:

You can contribute a PR but i'm affraid that it won't be easy one


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#412 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEFNKMNH1379cLtXt4Yie5pUAUe6eXuLks5qsAs1gaJpZM4JZro8
.

mwesolowski added a commit that referenced this issue Oct 15, 2016
@mwesolowski
Copy link
Member

@mwesolowski mwesolowski commented Oct 15, 2016

@bartoszwalacik please take a look at the branch https://github.com/javers/javers/tree/issue-412-shallow-reference-for-properties This is my first attempt to solve this issue. I'm sure you can provide me with some tips what can be improved.

@bartoszwalacik
Copy link
Member

@bartoszwalacik bartoszwalacik commented Oct 18, 2016

great, will take a look

@bartoszwalacik
Copy link
Member

@bartoszwalacik bartoszwalacik commented Oct 26, 2016

done in release 2.5.0

@croffler
Copy link
Author

@croffler croffler commented Oct 26, 2016

Awesome

On Wed, Oct 26, 2016 at 7:32 AM, Bartosz Walacik notifications@github.com
wrote:

Closed #412 #412.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#412 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEFNKIy3NJoSFJZM2WvPCeVWWmalaETUks5q3uXzgaJpZM4JZro8
.

@LucasDesenv
Copy link

@LucasDesenv LucasDesenv commented Oct 26, 2016

Nice one, @mwesolowski !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.