Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit property size too small in PostGres #462

Closed
gmadkat opened this issue Nov 16, 2016 · 7 comments
Closed

Commit property size too small in PostGres #462

gmadkat opened this issue Nov 16, 2016 · 7 comments
Labels

Comments

@gmadkat
Copy link

@gmadkat gmadkat commented Nov 16, 2016

Can we have the commit property value to be larger than 200? we need it at least to be 1024

CREATE TABLE dave.jv_commit_property
(
  property_name character varying(200) NOT NULL,
  property_value character varying(200),
  commit_fk bigint NOT NULL,
  CONSTRAINT jv_commit_property_pk PRIMARY KEY (commit_fk, property_name),
  CONSTRAINT jv_commit_property_commit_fk FOREIGN KEY (commit_fk)
      REFERENCES dave.jv_commit (commit_pk) MATCH SIMPLE
      ON UPDATE NO ACTION ON DELETE NO ACTION
)

@gmadkat
Copy link
Author

@gmadkat gmadkat commented Nov 16, 2016

I am happy to make any changes and submit a pull request if you are ok accepting them.

@bartoszwalacik
Copy link
Member

@bartoszwalacik bartoszwalacik commented Nov 16, 2016

I dont think it is a goog idea. Commit properties are designed as short tags, useful for querying and not for storing large data. What kind of data you want to store as commit property ?

@gmadkat
Copy link
Author

@gmadkat gmadkat commented Nov 16, 2016

We have a requirement where we are porting legacy Postgres tables with comments which are over 512 characters, from a system that is not JaVers, We might be able to live with 512 or 600 but definitely 200 is too short for us.
I am guessing there is no size limit for Mongo? Only in relational databases?

This is an urgent issue for us, so please let us know if you would consider increasing the comment size, otherwise we will have to find another workaround.

@bartoszwalacik
Copy link
Member

@bartoszwalacik bartoszwalacik commented Nov 17, 2016

yes, there is no limits in Mongo. As a quick workaround, simply run ALTER COLUMN on this column

@gmadkat
Copy link
Author

@gmadkat gmadkat commented Nov 17, 2016

Thank you, do you know when you can fix the size and if so, what is the new size you will use?

@bartoszwalacik
Copy link
Member

@bartoszwalacik bartoszwalacik commented Nov 17, 2016

seems not very urgent as you have workaround. I will set size to 600 as you suggest. It will be released with the next release

bartoszwalacik added a commit that referenced this issue Nov 17, 2016
@bartoszwalacik
Copy link
Member

@bartoszwalacik bartoszwalacik commented Nov 29, 2016

fixed in 2.7.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants