Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mongo DocumentConverter can not convert boolean #494

Closed
fsoylemez opened this issue Jan 23, 2017 · 8 comments
Closed

Mongo DocumentConverter can not convert boolean #494

fsoylemez opened this issue Jan 23, 2017 · 8 comments
Labels

Comments

@fsoylemez
Copy link

@fsoylemez fsoylemez commented Jan 23, 2017

Hello,
fromJsonElement method throws illegalargumentexception( unsupported jsonelement type) if it faces a Boolean value.(version 2.9.1)

@bartoszwalacik bartoszwalacik added the bug label Jan 23, 2017
@bartoszwalacik
Copy link
Member

@bartoszwalacik bartoszwalacik commented Jan 23, 2017

ok, we will fix it

@bartoszwalacik
Copy link
Member

@bartoszwalacik bartoszwalacik commented Jan 23, 2017

can't reproduce, I've added the new test to catch this bug but the test is passing - a9bbc57

could you please post a reproduction scenario?

@fsoylemez
Copy link
Author

@fsoylemez fsoylemez commented Jan 24, 2017

Hi Bartosz,
problem resolved when i added lines
"
if(list.isBoolean()) {
return Boolean.valueOf(jsonElement.getAsBoolean());
}
"
thank you for the quick response.

@bartoszwalacik
Copy link
Member

@bartoszwalacik bartoszwalacik commented Jan 24, 2017

Ok, but still, how can I reproduce the issue in a test case?

@bartoszwalacik
Copy link
Member

@bartoszwalacik bartoszwalacik commented Jan 24, 2017

ok, I have the repro, there was a bug in this new test case. I'm working on the fix ..

bartoszwalacik added a commit that referenced this issue Jan 24, 2017
@bartoszwalacik
Copy link
Member

@bartoszwalacik bartoszwalacik commented Jan 25, 2017

fixed in 2.9.2

@fsoylemez
Copy link
Author

@fsoylemez fsoylemez commented Jan 25, 2017

thank you!
sorry that i couldnt return in time with the scenario.

@fsoylemez fsoylemez closed this Jan 25, 2017
@bartoszwalacik
Copy link
Member

@bartoszwalacik bartoszwalacik commented Jan 25, 2017

It is public since today morning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.