Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Javers uses deprecated type TEXT for mssql for Snapshot_State and Snapshot_Changed fields #497
Looking at FixedSchemaFactory as well as my installation of Microsoft Sql Server, it appears that javers is using the TEXT datatype for the STATE and CHANGED_PROPERTIES fields in the jv_snapshot table. The text datatype has been deprecated in mssql since SQL Server 2005.
(Unable to create a unit test to show this.)
Unsure, it depends on polyjdbc's fix. If they add a way to set varchar max, then I would just use that. I suppose that this could be moved to a blocked status waiting on what we hear back from polyjdbc. I just figure that eventually TEXT won't be an option in sql server.
VARCHAR(MAX) would just be another type that polyjdbc would allow. VARCHAR(MAX) is actually bounded at a max of 2147483647 non unicode characters just like TEXT is. Ideally you would just select the new varcharMax() (If one was created.) type from polyjdbc. In MSSQL you can specify VARCHAR(MAX) just as you would specify any other data type, it's a datatype itself.
referenced this issue
Jun 17, 2017
@bartoszwalacik I have made the change but I am unaware of how to get the integration tests working for mssql, I created my database polly on my localhost:1433 instance, I then created user polly with pass polly with all permissions but when running the tests It fails all of them, due to what looks like it not connecting.
Not sure if there is some configuration that I am missing in setting this up. Otherwise the other unit tests are passing fine.
Note that before I create a PR I am waiting on @adamdubiel to tag a new version of polyjdbc.
EDIT: I saw that the username, pass, and db was set for a connection in MsSqlIntegrationTest.groovy that's where I got the username, pass, and dbname from