/javers

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JaversMethodFactory.methodKey(Method) could generate duplicate ids #499

Closed
sschedl opened this Issue Feb 20, 2017 · 2 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
2 participants
@sschedl @bartoszwalacik
@sschedl

sschedl commented Feb 20, 2017

Hello,

I found the problem that some properties get ignored in the diff, I could track it down to JaversMethodFactory.methodKey that generates duplicate ids for:
ShaDigest.shortDigest("isOrOperation") = 32757
ShaDigest.shortDigest("getCmdline") = 32757

I'm using javers 2.9.1

Best Regards

Stefan
@bartoszwalacik

This comment has been minimized.

Sign in to view
Member

bartoszwalacik commented Feb 20, 2017

thanks for reporting, I'll check it out

bartoszwalacik added a commit that referenced this issue Feb 24, 2017

@bartoszwalacik
#499 
error reproduction
Loading status checks…
140df63

bartoszwalacik added a commit that referenced this issue Feb 26, 2017

@bartoszwalacik
#499 
method keys removed
3b1e070

@bartoszwalacik bartoszwalacik added bug fixed labels Mar 3, 2017

@bartoszwalacik

This comment has been minimized.

Sign in to view
Member

bartoszwalacik commented Mar 3, 2017

fixed in 3.0.2

@bartoszwalacik bartoszwalacik closed this Mar 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment