Incorrect change reported for maps with array-typed values #546
Comments
Hi @neal-erickson , thanks for reporting. Looks like there is a problem with array.equals() in Java.
Looks like we should use Arrays.equals instead. We can do it, but still, since you have arrays nested in Maps, you will get only basic diff (Javers treats arrays as Values in this case) |
bartoszwalacik
added a commit
that referenced
this issue
Jun 25, 2017
bartoszwalacik
added a commit
that referenced
this issue
Jun 25, 2017
fixed in 3.3.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Was trying to find an existing issue for this, but couldn't - might not have done a good job though! I'm working with your otherwise excellent library for comparing some kafka serialization classes I'm writing and found an odd behavior. One of the objects I'm comparing has a field of type
Map<String, UUID[]>
and when I serialize/deserialize it I find that Javers reports aMapChange
change for that value, despite the UUID within the array being identical. This simple JUnit test reproduces the issue:Let me know if I'm missing something obvious here, but I couldn't find anything. Thanks for your time.
The text was updated successfully, but these errors were encountered: