Npe while gettings shadows

[fsoylemez]

Hello,
I am getting NullPointerException while trying to get shadows of an entity.
I build the query with instanceId and with parameter shadowscopedeep.And i have 'to' parameter set,as i want the latest shadow (if exist) till the provided time.(My javers version is 3.3.2)

This is how i call it;
` DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm");

    E model = findById(id);
    QueryBuilder queryBuilder = QueryBuilder.byInstanceId(id, model.dtoClass()).withShadowScopeDeep();
    if(from!=null && !from.isEmpty()){
        queryBuilder.from(LocalDateTime.parse(from,formatter));
    }
    if(to!=null && !to.isEmpty()){
        queryBuilder.to(LocalDateTime.parse(to,formatter));
    }
    List<Shadow<E>> shadows = javers.findShadows(queryBuilder.build());`

And here is the stacktrace:
Caused by: java.lang.NullPointerException at org.javers.repository.jql.ShadowQueryRunner$CommitTable.lambda$loadFullCommits$78(ShadowQueryRunner.java:94) at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1374) at java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:580) at org.javers.repository.jql.ShadowQueryRunner$CommitTable.loadFullCommits(ShadowQueryRunner.java:94) at org.javers.repository.jql.ShadowQueryRunner.queryForShadows(ShadowQueryRunner.java:36) at org.javers.repository.jql.QueryRunner.queryForShadows(QueryRunner.java:40) at org.javers.core.JaversCore.findShadows(JaversCore.java:143) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498)

[bartoszwalacik]

Okay, could you please post the full code needed to reproduce this NPE?

[fsoylemez]

i am guessing it is about setting from/to fields.Because if i comment out setting from/to,no exception is thrown.i will try to prepare test case to reproduce the situation.

[fsoylemez]

the problem is commitsMap is empty while trying to append CommitEntry like;
((ShadowQueryRunner.CommitEntry)this.commitsMap.get(s.getCommitMetadata())).append(s);

[bartoszwalacik]

Okay, waiting for the test case

[fsoylemez]

public List<Shadow> queryForShadows(JqlQuery query, List<CdoSnapshot> coreSnapshots) {
       ShadowQueryRunner.CommitTable commitTable = new ShadowQueryRunner.CommitTable(coreSnapshots);
       if(query.getShadowScope() == ShadowScope.COMMIT_DEPTH) {
           commitTable.loadFullCommits();
       }

       return (List)commitTable.rootsForQuery(query).stream().map((r) -> {
           return this.shadowFactory.createShadow(r.root, r.context, (cm, targetId) -> {
               return commitTable.findLatestTo(cm, targetId);
           });
       }).collect(Collectors.toList());
   }

Hello Bartos,
I think the above method should return empty list at the very beginning of the method if coreSnapshots list is empty.Since we have no match,there is no need to go on.Dont you agree?

[bartoszwalacik]

Use three backticks to format code :)

[fsoylemez]

Hello ,
any update on the issue?

[bartoszwalacik]

We cant start without a failing test case, please push it to your fork of javers repository

[fsoylemez]

Okay,i may sound noob,but i pulled your master branch and prepared a test case.How do i send merge request?

[bartoszwalacik]

ok, now I can reproduce it on my machine, we will fix the bug

[bartoszwalacik]

fix released in 3.3.4