Replace string id feature

[ismaelgcosta]

I need a feature to override tha method called to create the id of the entity.

I have a composite id with entities embbeded. So I created a new annotation to customize Javers to use a defined method not toString Object.

So before Javers created globalId like = 'dummyEntityWithCompositeEmbeddedId/org.javers.core.model.DummyPoint@5b10,1'

and with this new feature I can customize for = 'dummyEntityWithCompositeEmbeddedId/1,2,1'

Here is my pull request #613. Sorry about my last issues. I should read the CONTRIBUTING.md before

[bartoszwalacik]

Did you tried to implement custom Type Adapter ?
see https://javers.org/documentation/domain-configuration/#ValueType

[ismaelgcosta]

My difficulty isn't the serialization of cdoId. My problem is the serialization of globalId_key field.
And this is part of javers core. I know my feature can be looks like a personal necessity but if you run my tests without the new feature you will see globalId_key is equal 'dummyEntityWithCompositeEmbeddedId/org.javers.core.model.DummyPoint@5b10,1'

My worry is about maintenance of snapshots. I will never can find by globalId_key because it was saved with object reference not with my real values.

[bartoszwalacik]

ok , got it, that's resonable

[ismaelgcosta]

Thank you. Please if it's all right can you merge this feature? I need to use that next week in my job.

Thanks for your patience

[bartoszwalacik]

will try , but CR first

[bartoszwalacik]

I have looked at the PR, why another annotation? If you can add annotation to this class why you cant just fix its toString()?

Btw, sometimes you can't modify a class (think about legacy code or libraries code).

I think about more versatile and simpler solution with Function:

API (JaversBuilder)

public <T> void registerToStringFunction(Class<T> clazz, Function<T, String> toString);

usage

javersBuilder.registerToStringFunction(YourClass.class, YourClass::customTtoString);

[ismaelgcosta]

I agree with you, it's a better solution then my. I will adjust the code

[bartoszwalacik]

fine :)

[ismaelgcosta]

I made the changes you suggested. Can you review my code again please?

[ismaelgcosta]

I'm still work in a solution, as soon as possible I will commit it. Tks :)

[bartoszwalacik]

ok, let me know when you will be ready :)

[ismaelgcosta]

Hi, I finished my changes. Can you review for me please?

[bartoszwalacik]

Guys, I appreciate your effort. I did some changes to the API and impl to make the code more javers-way. Take a look at the tests, is it OK now?