Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistng commitDate with milliseconds precision on MySql #664

Closed
bartoszwalacik opened this issue Apr 24, 2018 · 5 comments
Closed

Persistng commitDate with milliseconds precision on MySql #664

bartoszwalacik opened this issue Apr 24, 2018 · 5 comments
Labels

Comments

@bartoszwalacik
Copy link
Member

@bartoszwalacik bartoszwalacik commented Apr 24, 2018

related PR to poly - polyjdbc/polyjdbc#38
reasons, see #657

@bartoszwalacik
Copy link
Member Author

@bartoszwalacik bartoszwalacik commented Apr 24, 2018

@gbondarchuk9 we need to wait a while for the poly release

bartoszwalacik added a commit that referenced this issue Apr 24, 2018
schema migration
bartoszwalacik added a commit that referenced this issue Apr 24, 2018
"should persit commitDate with milliseconds precision"
@bartoszwalacik
Copy link
Member Author

@bartoszwalacik bartoszwalacik commented Apr 24, 2018

col type is changed to timestamp(3) but MySql still writes without millis (see the test added in the last commit)
@gbondarchuk9, any ideas what's wrong?

@gbondarchuk9
Copy link

@gbondarchuk9 gbondarchuk9 commented Apr 24, 2018

@bartoszwalacik I cannot find the test you're talking about, could you please refer with direct link to code?

by the way, I don't see any lines of code related to altering table with timestamp(3)

@bartoszwalacik
Copy link
Member Author

@bartoszwalacik bartoszwalacik commented Apr 25, 2018

@gbondarchuk9 links are here, look up, just above my previous comment

bartoszwalacik added a commit that referenced this issue Apr 26, 2018
polyjdbcVersion=0.7.3
bartoszwalacik added a commit that referenced this issue Apr 26, 2018
test fixes
@bartoszwalacik
Copy link
Member Author

@bartoszwalacik bartoszwalacik commented Apr 26, 2018

fix released in 3.9.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.