Stopping diff to go one level deep #669
Closed
Labels
Comments
That's how Javers works. You can use |
@bartoszwalacik , thanks! Really appreciate the response |
Okay, looks like that you can't compare Value Objects in List wit AS_SET algorithm. Normally, when a Value Object is in Set, its Id is generated using ObjectHasher, for example:
If Value Object is in List, its Id is based on its index in this List, for example:
When you AS_SET is chosen, Id should be generated using ObjectHasher for both Set and List containers |
So pottenitaly a bug that you would fix? |
yes |
bartoszwalacik
added a commit
that referenced
this issue
May 9, 2018
fix for comparing VO in List with AS_SET
bartoszwalacik
added a commit
that referenced
this issue
May 9, 2018
fixed in release 3.9.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have a normal program which does below
Below is the repo if you need to have a look
https://github.com/tarunlalwani/javers-diff-issue
Now when you run the diff is like below
All the changes are actually covered by below
But
javers
still goes one level deep again in the list and does another comparison and adds belowBug/feature/limitation? Need to understand. If the list has been already compared, I don't want it to go one level deep again and of course
@ShallowReference
doesn't helpThe text was updated successfully, but these errors were encountered: