New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support current versions of Spring Data (2.x) #677

Closed
shollander opened this Issue May 10, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@shollander
Contributor

shollander commented May 10, 2018

Current versions of Spring Data use saveAll(Iterable) instead of save(Iterable). When used with JaversSpringDataAuditableRepositoryAspect, calls to saveAll() are ignored. I believe this is a simple fix that just requires the addition of another pointcut definition in JaversSpringDataAuditableRepositoryAspect. delete(Iterable) has also been renamed to deleteAll(Iterable).

See DATACMNS-944 and 727ab8384cac21e574526f325e19d6af92b8c8df.

@bartoszwalacik

This comment has been minimized.

Member

bartoszwalacik commented May 11, 2018

yes, looks like a simple fix in the pointcut definition. Please create a pull request.

shollander added a commit to shollander/javers that referenced this issue May 14, 2018

bartoszwalacik added a commit that referenced this issue May 16, 2018

Merge pull request #679 from shollander/master
#677 Support Spring Data 2.x
@bartoszwalacik

This comment has been minimized.

Member

bartoszwalacik commented May 17, 2018

released in 3.9.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment