Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
JaVers dependency on Google Guava #692
As documented I just ran the below code to view the diff. It seems that Google Guava is required as a runtime dependency for the below code to work.
Javers javers = JaversBuilder.javers().build(); Person tommyOld = new Person("tommy", "Tommy Smart"); Person tommyNew = new Person("tommy", "Tommy C. Smart"); Diff diff = javers.compare(tommyOld, tommyNew); System.out.println(diff.prettyPrint());
The code above throws an exception as shown below:
Not sure how the below line of code is used in org.javers.core.Changes.java
The above code can be easily replaced with standard Java code to remove dependency on Goolge Guava.
Do let me know if these changes can be done. I will submit a PR.
Thanks for reporting. You are right, there should be no references to Guava in javers-core classes (except of
and should not be required. I will be happy if you contribute a PR to fix it.
added a commit
Aug 4, 2018
@PodusovMaxim What version are you using? I looked inside the