Skip to content

/ javers

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracking a top-level object deletion #71

Closed
bartoszwalacik opened this issue Dec 17, 2014 · 3 comments
Closed

tracking a top-level object deletion #71

bartoszwalacik opened this issue Dec 17, 2014 · 3 comments
Assignees
@bartoszwalacik

Comments

@bartoszwalacik
Copy link
Member

@bartoszwalacik bartoszwalacik commented Dec 17, 2014

How would I go about tracking a top-level object deletion? So if I remove an entity completely from my database, how do I "commit" that change to Javers?

we need new method:

javers.commitDelete(String author, Object deleted);
@bartoszwalacik bartoszwalacik mentioned this issue Dec 17, 2014
Closed
@pszymczyk pszymczyk self-assigned this Dec 18, 2014
bartoszwalacik added a commit that referenced this issue Jan 11, 2015
@bartoszwalacik
https://github.com//issues/71
97bf3be 
first, failing tests
bartoszwalacik added a commit that referenced this issue Jan 11, 2015
@bartoszwalacik
https://github.com//issues/71
bc7152b 
SnapshotType
bartoszwalacik added a commit that referenced this issue Jan 11, 2015
@bartoszwalacik
https://github.com//issues/71
Loading status checks…
88eddff 
tracking Removed objects
@bartoszwalacik bartoszwalacik mentioned this issue Jan 11, 2015
Merged
bartoszwalacik added a commit that referenced this issue Jan 11, 2015
@bartoszwalacik
https://github.com//issues/71
Loading status checks…
166b82c 
rename: commitDelete() -> commitShallowDelete()
@bartoszwalacik
Copy link
Member Author

@bartoszwalacik bartoszwalacik commented Jan 12, 2015

solved, waiting to CR. To be released in 1.0.3
@ctmay4
Copy link

@ctmay4 ctmay4 commented Jan 12, 2015

Just tested on the snapshot and it worked well with my tests. Thanks.
@bartoszwalacik
Copy link
Member Author

@bartoszwalacik bartoszwalacik commented Jan 13, 2015

1.0.3 released to Central
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bartoszwalacik bartoszwalacik

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@ctmay4 @bartoszwalacik @pszymczyk
You can’t perform that action at this time.