Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method-level annotation should enable delete method to save terminal snapshots #751

Closed
guima opened this issue Nov 26, 2018 · 10 comments
Closed
Labels
contribution wanted this feature is wanted but won't be implemented by core team due to limited resources fixed new feature

Comments

@guima
Copy link
Contributor

guima commented Nov 26, 2018

When using ordinary repositories, we would like to annotate delete methods and save terminal snapshots.

We annotated save and delete repository methods with @JaversAuditable, but only initial and update snapshots were persisted.

We want to enable commitShallowDelete to save terminal snapshots without Spring Data.

@bartoszwalacik bartoszwalacik added contribution wanted this feature is wanted but won't be implemented by core team due to limited resources new feature labels Nov 27, 2018
@bartoszwalacik
Copy link
Member

The new ann should be named @JaversAuditableDelete, looks like this task is easy to implement, feel free to contribute a PR

guima added a commit to guima/javers that referenced this issue Dec 20, 2018
@dovidkopel
Copy link

Has this been merged in yet?

@bartoszwalacik
Copy link
Member

there is nothing to merge, someone has to code it first :)

@guima
Copy link
Contributor Author

guima commented Feb 12, 2019

I already forked and committed It. What should i do now?

@bartoszwalacik
Copy link
Member

Please create a pull request

bartoszwalacik added a commit that referenced this issue Feb 16, 2019
merging the new aspect with the old one, thanks to that we dont need to change the docs and users' config
@bartoszwalacik
Copy link
Member

nice job @guima

I will release it in this weekend in 5.2.0

I did some changes (merging the new aspect with the old one, thanks to that we don't won't have to change the docs and users' config)

@bartoszwalacik
Copy link
Member

released in 5.2.0

@ghost
Copy link

ghost commented Jul 14, 2019

can Javers only persist on save and delete methods? can it save snapshot on .update?

@ravivarmakola
Copy link

@bartoszwalacik The documentation says:

@JaversAuditableDelete
TODO

Is it the documentation to be done ? is the change already in JaVers post 5.2.0 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution wanted this feature is wanted but won't be implemented by core team due to limited resources fixed new feature
Projects
None yet
Development

No branches or pull requests

4 participants