Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method-level annotation should enable delete method to save terminal snapshots #751

Closed
guima opened this Issue Nov 26, 2018 · 7 comments

Comments

Projects
None yet
3 participants
@guima
Copy link
Contributor

guima commented Nov 26, 2018

When using ordinary repositories, we would like to annotate delete methods and save terminal snapshots.

We annotated save and delete repository methods with @JaversAuditable, but only initial and update snapshots were persisted.

We want to enable commitShallowDelete to save terminal snapshots without Spring Data.

@bartoszwalacik

This comment has been minimized.

Copy link
Member

bartoszwalacik commented Nov 27, 2018

The new ann should be named @JaversAuditableDelete, looks like this task is easy to implement, feel free to contribute a PR

guima added a commit to guima/javers that referenced this issue Dec 20, 2018

@dovidkopel

This comment has been minimized.

Copy link

dovidkopel commented Feb 11, 2019

Has this been merged in yet?

@bartoszwalacik

This comment has been minimized.

Copy link
Member

bartoszwalacik commented Feb 12, 2019

there is nothing to merge, someone has to code it first :)

@guima

This comment has been minimized.

Copy link
Contributor Author

guima commented Feb 12, 2019

I already forked and committed It. What should i do now?

@bartoszwalacik

This comment has been minimized.

Copy link
Member

bartoszwalacik commented Feb 12, 2019

Please create a pull request

bartoszwalacik added a commit that referenced this issue Feb 16, 2019

#751
merging the new aspect with the old one, thanks to that we dont need to change the docs and users' config
@bartoszwalacik

This comment has been minimized.

Copy link
Member

bartoszwalacik commented Feb 16, 2019

nice job @guima

I will release it in this weekend in 5.2.0

I did some changes (merging the new aspect with the old one, thanks to that we don't won't have to change the docs and users' config)

@bartoszwalacik

This comment has been minimized.

Copy link
Member

bartoszwalacik commented Feb 16, 2019

released in 5.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.