Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
If you use org.javers.core.diff.custom.CustomBigDecimalComparator with a null value you get an NPE
There should be a null check for setScale and possibly for aRounded.equals(bRounded); aswell.
Also minor issue
The comment in line 21 is missing the .class -> BigDecimal.class
JaversBuilder.javers().registerCustomComparator(new CustomBigDecimalComparator(2), BigDecimal).build();
The text was updated successfully, but these errors were encountered:
You are right. CustomBigDecimalComparator is here just to serve as the example of CustomComparator, so it's not critical. Contribute a PR with the fix if you like.
Sorry, something went wrong.
Yeah it is not critical :)
i have written my own Comparator
PR -> 771
merged, it will be released in the next release
fix released in 5.2.0
Successfully merging a pull request may close this issue.