Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to provide object dependent map for CommitPropertiesProvider. #870

Closed
chioai1309 opened this issue Aug 25, 2019 · 5 comments

Comments

@chioai1309
Copy link

commented Aug 25, 2019

According to open question state here https://stackoverflow.com/questions/57518008/is-there-possibility-to-provide-object-dependent-map-for-commitpropertiesprovide.

We would like to have a domain object parameter for the CommitPropertiesProvider in order to provide the commit properties for context dependent in order to using commit-property-filter feature later on.

public class CustomCommitPropertiesProvider implements CommitPropertiesProvider {
   public Map<String, String> provide(Object domainObject) {
        if (domainObject instanceof ModerationEntity) {
            // return map with key = "listId" & value = ModerationEntity#listId
        }
        // return emptyMap
    }
}
@bartoszwalacik

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

Makes sense, we are waiting for your PR :)

@chioai1309

This comment has been minimized.

Copy link
Author

commented Sep 1, 2019

The PR is created #873. Sorry there's a mistake on the commit message refer to the wrong issue number (860 instead of 870)

@bartoszwalacik

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

ok, i'm working on it. the biggest issue is keeping backward compatibility

bartoszwalacik added a commit that referenced this issue Sep 2, 2019
https://github.com//issues/870
keeping backward compatibility (work in progress)
bartoszwalacik added a commit that referenced this issue Sep 2, 2019
bartoszwalacik added a commit that referenced this issue Sep 2, 2019
bartoszwalacik added a commit that referenced this issue Sep 2, 2019
bartoszwalacik added a commit that referenced this issue Sep 3, 2019

@bartoszwalacik bartoszwalacik added the fixed label Sep 3, 2019

@bartoszwalacik

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

released in 5.7.0, @chioai1309 thanks for your contribution!

bartoszwalacik added a commit that referenced this issue Sep 3, 2019
https://github.com//issues/870
refreshed examples of CommitPropertiesProvider
@chioai1309

This comment has been minimized.

Copy link
Author

commented Sep 4, 2019

@bartoszwalacik : you're welcome. Thank you very much for the quick release. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.